The proper place to clean up resources of objects is in their
destructor. This makes sure proper cleanup when edge_del() is called as
well. At exit, free_edge() is called on all edges by free_edge_tree(),
which is called by exit_nodes().
Let configure include sys/if_tun.h when testing for netinet/if_ether.h
to detect the Kernel/libc header conflict on musl.
After this patch, configure will correctly detect netinet/if_ether.h as
unusable and the subsequent compilation will not attempt to use it.
Conflicts:
src/have.h
With AutoConnect = yes, tinc tries to establish connections to known hosts.
However, you could have set no Address for this host, which is perfectly fine
(as long as there is at least one bootstrap node with an address or a local
discovered node already part of the network)
So log this to LOG_DEBUG
In a "decentrally managed vpn" it is very likely that host config
files for some reachable nodes do not exist. Currently, tinc
fills the logs with "Cannot open config file" messages.
This commit changes the log level to LOG_DEBUG so
syslog doesn't get filled by default.
(gdb) bt
#0 mst_kruskal () at graph.c:107
#1 graph () at graph.c:302
#2 0x00007ffff7b509fe in del_edge_h (c=<optimized out>, request=<optimized out>) at protocol_edge.c:292
#3 0x00007ffff7b4de2e in receive_request (c=0x5555557e3ef0, request=0x555555800e13 "13 3fc17404 node1 node2") at protocol.c:136
#4 0x00007ffff7b43513 in receive_meta (c=0x5555557e3ef0) at meta.c:290
#5 0x00007ffff7b442d9 in handle_meta_connection_data (c=0x5555557e3ef0) at net.c:291
#6 0x00007ffff7b41391 in event_loop () at event.c:287
#7 0x00007ffff7b449b2 in main_loop () at net.c:469
#8 0x0000555555556716 in main (argc=<optimized out>, argv=<optimized out>) at tincd.c:480
To compile the test you will need cmocka installed on system.
Checks in configure.ac are still missing.
$ cd tinc/test/; make simple
to generate testing directory you can use cmocka-simple.sh
$ ./cmocka-simple.sh
‘mocks/conf1’ -> ‘/tmp/tmp.PtS9r796ns/conf1’
To run the test do: cd /tmp/tmp.PtS9r796ns ; ./simple
$ ./simple
[==========] Running 6 test(s).
[ RUN ] test_edge_init
0 != 0x2
simple.c:73: error: Failure!
[ FAILED ] test_edge_init
[ RUN ] test_read_config_file
[ OK ] test_read_config_file
[ RUN ] test_config_add_item
[ OK ] test_config_add_item
[ RUN ] test_config_add_item_no_filename
value
simple.c:234: error: Failure!
[ FAILED ] test_config_add_item_no_filename
[ RUN ] test_splay_tree_init
[ OK ] test_splay_tree_init
[ RUN ] test_splay_tree_basic
[ OK ] test_splay_tree_basic
[==========] 6 test(s) run.
[ PASSED ] 4 test(s).
[ FAILED ] 2 test(s), listed below:
[ FAILED ] test_edge_init
[ FAILED ] test_config_add_item_no_filename
2 FAILED TEST(S)
