mirror of
https://github.com/retspen/webvirtcloud
synced 2026-11-08 11:16:47 +00:00
680dd5dad4
Plan reviewed with Codex; tried on a udev host (AlmaLinux 10) and a netcf one (AlmaLinux 8). - Changes are one change of the host's configuration (libvirt's interface change transaction): a bridge that does not start used to be undefined, leaving its member without the addresses and start mode the bridge took from it; now the whole change rolls back, the member's own configuration too, and so does a commit libvirt refuses. A rollback that fails too is reported with the failure, saying the host's configuration may be changed. Deleting a bridge, which defines its members again on their own, is one change as well. - A running interface is not deleted: the page hid Delete, but a post deleted it. A bridge with addresses and several members is refused (which member takes the addresses is the user's choice); the confirmation says that its members are defined again. - A bridge takes only a device in no bridge, bond or VLAN as the host has them configured, at any depth (a bridge's bond's devices), not the loopback, a libvirt network's bridge or a VM's tap; an ethernet interface configures only such a device too. - Whether the host can change interfaces: unsupported or refused by its access rules is a no, bad XML a yes, anything else (the connection, the login) is raised instead of taken for a yes. A page whose host could not be read offers no actions. - Reads: the list reads each interface's XML once from one listing (listAllInterfaces: every state, not the active and the defined ones apart); a page reads the running and the saved definition once each (cached_property). netcf writes a link speed of -1 for a card that has none (a virtio one) and then refuses its own XML: the saved one is read instead, where virsh and the page failed. Name and MAC come from libvirt's object, without a call. Each family says how it is addressed (DHCP, autoconf, static or none) and every address, its prefix where it has one; no address is not "DHCP" any more. A bridge's members carry their link state and speed; an unknown speed (0, -1, 4294967295) is none. - The interface API lists from the same reader. get_details, get_bridge, get_bridge_slave_ifaces and the per-family getters go.
39 lines
1.8 KiB
Python
39 lines
1.8 KiB
Python
"""Host interface changes write rows on the Logs page."""
|
|
|
|
from unittest.mock import patch
|
|
|
|
from computes.models import Compute
|
|
from django.contrib.auth import get_user_model
|
|
from django.test import TestCase
|
|
from django.urls import reverse
|
|
|
|
from logs.models import Logs
|
|
|
|
|
|
class InterfaceRowTests(TestCase):
|
|
def setUp(self):
|
|
self.compute = Compute.objects.create(name="c1", hostname="localhost", login="", password="", type=4)
|
|
self.client.force_login(get_user_model().objects.create_superuser("audit-admin", "a@example.com", "pw"))
|
|
Logs.objects.all().delete() # the login's row
|
|
|
|
@patch("interfaces.views.wvmInterface")
|
|
@patch("interfaces.views.wvmInterfaces")
|
|
def test_interface_actions(self, ifaces, iface):
|
|
ifaces.return_value.can_change_interfaces.return_value = True
|
|
ifaces.return_value.get_net_devices.return_value = ["eth0"]
|
|
ifaces.return_value.get_member_candidates.return_value = ["eth0"]
|
|
ifaces.return_value.get_ifaces_info.return_value = []
|
|
iface.return_value.can_change_interfaces.return_value = True
|
|
self.client.post(reverse("interfaces", args=[self.compute.id]), {
|
|
"create": "", "name": "br1", "itype": "bridge", "start_mode": "onboot", "netdev": "eth0",
|
|
"ipv4_type": "dhcp", "ipv6_type": "none", "stp": "on", "delay": "0"})
|
|
ifaces.return_value.create_iface.assert_called_once()
|
|
url = reverse("interface", args=[self.compute.id, "br1"])
|
|
for action in ("start", "stop", "delete"):
|
|
self.client.post(url, {action: ""})
|
|
self.assertEqual(list(Logs.objects.order_by("id").values_list("message", "success", "host")), [
|
|
("Interface br1: add", True, "c1"),
|
|
("Interface br1: start", True, "c1"),
|
|
("Interface br1: stop", True, "c1"),
|
|
("Interface br1: delete", True, "c1"),
|
|
])
|