catborise 17016e90cd fix(computes): a compute's hostname and login cannot inject a connection URI or ssh option ... A compute's hostname and login go unquoted into the libvirt connection URI (qemu+ssh://login@host/system, qemu+tcp://host/system, qemu+tls://...) and, for an SSH compute, into the ssh command line of the DRBD status view. They were barely validated: validate_hostname used re.match with a negated class, so it caught only a leading special character, and login was never checked. A hostname like "192.0.2.1/system?command=/path" injected a libvirt URI parameter (verified: connecting ran the named command through the ssh wrapper), and TLS/SSH parameters such as no_verify, pkipath, socket or netcat could be added the same way; a login like "-oProxyCommand=..." became an ssh option. The DRF ComputeSerializer applied neither check, and validate_name tested a string literal instead of its argument, so it never raised. validate_hostname now accepts only an IPv4 address or a host name with fullmatch (no scheme, port, path, query, whitespace or IPv6 literal; IPv6 is left out until the URI building brackets it). validate_login accepts an empty value (TCP falls back to the server's authentication, the socket transport ignores the login) or a plain name with no leading "-". Both sit on the Compute model fields, so the forms and the DRF serializer (which copies model validators onto its fields) reject the values; a migration records the metadata. validate_name checks its argument. drbd_status validates the login and hostname before building login@host and ends ssh option parsing with "--"; an existing or bypassed bad row is skipped rather than run. Tests: hostname/login validators accept real values and reject URI and option injection; the SSH form and the serializer (create, and an empty TCP login) enforce them; drbd_status skips an injecting target. Checked the real test computes still validate. The new tests fail on the previous code.		2026-10-06 22:10:19 +03:00
..
0001_initial.py	Python3 & Django 2.2 Migration - Fix & Updates	2020-03-16 16:59:45 +03:00
0002_auto_20200529_1320.py	Reworked some computes forms and views	2020-05-29 19:25:36 +06:00
0003_auto_20200615_0637.py	Added missing migrations	2020-06-15 12:38:44 +06:00
0004_compute_migration_address.py	feat(computes): a compute names the address migrations reach it on	2026-10-06 15:05:40 +03:00
0005_alter_compute_hostname_alter_compute_login.py	fix(computes): a compute's hostname and login cannot inject a connection URI or ssh option	2026-10-06 22:10:19 +03:00
__init__.py	Initial commit	2015-02-27 10:53:51 +02:00