mirror of
https://github.com/retspen/webvirtcloud
synced 2026-11-08 19:26:48 +00:00
680dd5dad4
Plan reviewed with Codex; tried on a udev host (AlmaLinux 10) and a netcf one (AlmaLinux 8). - Changes are one change of the host's configuration (libvirt's interface change transaction): a bridge that does not start used to be undefined, leaving its member without the addresses and start mode the bridge took from it; now the whole change rolls back, the member's own configuration too, and so does a commit libvirt refuses. A rollback that fails too is reported with the failure, saying the host's configuration may be changed. Deleting a bridge, which defines its members again on their own, is one change as well. - A running interface is not deleted: the page hid Delete, but a post deleted it. A bridge with addresses and several members is refused (which member takes the addresses is the user's choice); the confirmation says that its members are defined again. - A bridge takes only a device in no bridge, bond or VLAN as the host has them configured, at any depth (a bridge's bond's devices), not the loopback, a libvirt network's bridge or a VM's tap; an ethernet interface configures only such a device too. - Whether the host can change interfaces: unsupported or refused by its access rules is a no, bad XML a yes, anything else (the connection, the login) is raised instead of taken for a yes. A page whose host could not be read offers no actions. - Reads: the list reads each interface's XML once from one listing (listAllInterfaces: every state, not the active and the defined ones apart); a page reads the running and the saved definition once each (cached_property). netcf writes a link speed of -1 for a card that has none (a virtio one) and then refuses its own XML: the saved one is read instead, where virsh and the page failed. Name and MAC come from libvirt's object, without a call. Each family says how it is addressed (DHCP, autoconf, static or none) and every address, its prefix where it has one; no address is not "DHCP" any more. A bridge's members carry their link state and speed; an unknown speed (0, -1, 4294967295) is none. - The interface API lists from the same reader. get_details, get_bridge, get_bridge_slave_ifaces and the per-family getters go.
92 lines
5.5 KiB
Python
92 lines
5.5 KiB
Python
"""What the panel reads of the host's interfaces: each one's XML once, its
|
|
link as reported (an unknown speed is none), its members; which devices a new
|
|
bridge can take; how each family is addressed."""
|
|
|
|
from unittest.mock import MagicMock
|
|
|
|
import libvirt
|
|
from django.test import SimpleTestCase
|
|
from vrtManager.interface import wvmInterface, wvmInterfaces
|
|
|
|
BRIDGE = ("<interface type='bridge' name='br0'><mtu size='1500'/><link speed='4294967295' state='up'/>"
|
|
"<mac address='52:54:00:aa:01:02'/><bridge stp='on' delay='0'>"
|
|
"<interface type='ethernet' name='eno1'><link speed='1000' state='up'/><mac address='52:54:00:aa:01:03'/></interface>"
|
|
"</bridge></interface>")
|
|
ETHERNET = "<interface type='ethernet' name='eno2'><link state='down'/><mac address='52:54:00:aa:01:04'/></interface>"
|
|
|
|
|
|
def iface(xml, active=1):
|
|
name = xml.split("name='")[1].split("'")[0]
|
|
mac = xml.split("mac address='")[1].split("'")[0]
|
|
return MagicMock(**{"name.return_value": name, "MACString.return_value": mac, "XMLDesc.return_value": xml,
|
|
"isActive.return_value": active})
|
|
|
|
|
|
def error(code):
|
|
err = libvirt.libvirtError("refused")
|
|
err.get_error_code = lambda: code
|
|
return err
|
|
|
|
|
|
class ReadTests(SimpleTestCase):
|
|
def interfaces(self, *xmls, networks=()):
|
|
conn = wvmInterfaces.__new__(wvmInterfaces)
|
|
conn.wvm = MagicMock(**{"listAllInterfaces.return_value": [iface(x) for x in xmls],
|
|
"listAllNetworks.return_value": [MagicMock(**{"XMLDesc.return_value": n}) for n in networks]})
|
|
return conn
|
|
|
|
def test_each_interface_is_read_once(self):
|
|
conn = self.interfaces(BRIDGE, ETHERNET)
|
|
br0, eno2 = conn.get_ifaces_info()
|
|
self.assertEqual((br0["type"], br0["link"], br0["speed"], br0["mtu"], br0["mac"]),
|
|
("bridge", "up", None, "1500", "52:54:00:aa:01:02"))
|
|
self.assertEqual(br0["members"], [{"name": "eno1", "type": "ethernet", "mac": "52:54:00:aa:01:03",
|
|
"link": "up", "speed": "1000"}])
|
|
self.assertEqual((eno2["link"], eno2["members"]), ("down", []))
|
|
for listed in conn.wvm.listAllInterfaces.return_value:
|
|
# name and MAC are held by libvirt's object: no call to the host
|
|
self.assertEqual([c[0] for c in listed.mock_calls], ["XMLDesc", "name", "MACString", "isActive"])
|
|
|
|
def test_an_interface_libvirt_cannot_write_is_read_as_saved(self):
|
|
# netcf writes a link speed of -1 for a virtio card, then refuses that XML
|
|
listed = iface(ETHERNET)
|
|
listed.XMLDesc.side_effect = lambda flags=0: ETHERNET if flags else (_ for _ in ()).throw(error(libvirt.VIR_ERR_XML_ERROR))
|
|
conn = self.interfaces()
|
|
conn.wvm.listAllInterfaces.return_value = [listed]
|
|
(eno2,) = conn.get_ifaces_info()
|
|
self.assertEqual(eno2["name"], "eno2")
|
|
|
|
def test_a_bridge_takes_no_bridge_member_network_bridge_or_tap(self):
|
|
# as configured: a member the running bridge does not have yet is taken too
|
|
conn = self.interfaces(BRIDGE, ETHERNET, networks=["<network><bridge name='virbr0'/></network>"])
|
|
self.assertEqual(conn.get_member_candidates(["br0", "eno1", "eno2", "lo", "virbr0", "vnet3", "macvtap0"]), ["eno2"])
|
|
for listed in conn.wvm.listAllInterfaces.return_value:
|
|
listed.XMLDesc.assert_called_with(libvirt.VIR_INTERFACE_XML_INACTIVE)
|
|
|
|
def test_a_device_in_a_bond_of_a_bridge_is_taken(self):
|
|
nested = ("<interface type='bridge' name='br1'><mac address='52:54:00:aa:01:05'/><bridge><interface type='bond' name='bond0'><bond>"
|
|
"<interface type='ethernet' name='eno3'/><interface type='ethernet' name='eno4'/></bond></interface>"
|
|
"</bridge></interface>")
|
|
conn = self.interfaces(nested)
|
|
self.assertEqual(conn.get_member_candidates(["br1", "bond0", "eno3", "eno4", "eno5"]), ["eno5"])
|
|
|
|
def test_each_family_says_how_it_is_addressed(self):
|
|
conn = wvmInterface.__new__(wvmInterface)
|
|
saved = ("<interface type='ethernet' name='eth0'><start mode='onboot'/>"
|
|
"<protocol family='ipv4'><ip address='198.51.100.10' prefix='24'/></protocol>"
|
|
"<protocol family='ipv6'><autoconf/></protocol></interface>")
|
|
running = ("<interface type='ethernet' name='eth0'><protocol family='ipv4'><ip address='198.51.100.10' prefix='24'/></protocol>"
|
|
"<protocol family='ipv6'><ip address='2001:db8::5' prefix='64'/><ip address='2001:db8::6' prefix='64'/></protocol></interface>")
|
|
conn.iface = MagicMock(**{"name.return_value": "eth0", "MACString.return_value": "52:54:00:00:00:01",
|
|
"XMLDesc.side_effect": lambda flags=0: saved if flags else running})
|
|
info = conn.get_info()
|
|
self.assertEqual(info["start_mode"], "onboot")
|
|
self.assertEqual(info["ipv4"], {"method": "static", "addresses": ["198.51.100.10/24"]})
|
|
self.assertEqual(info["ipv6"], {"method": "autoconf", "addresses": ["2001:db8::5/64", "2001:db8::6/64"]})
|
|
self.assertEqual(conn.iface.XMLDesc.call_count, 2) # the running and the saved definition, once each
|
|
|
|
def test_an_address_without_a_prefix_is_shown_without_one(self):
|
|
conn = wvmInterface.__new__(wvmInterface)
|
|
xml = "<interface type='ethernet' name='eth0'><protocol family='ipv4'><ip address='192.0.2.10'/></protocol></interface>"
|
|
conn.iface = MagicMock(**{"name.return_value": "eth0", "MACString.return_value": "", "XMLDesc.return_value": xml})
|
|
self.assertEqual(conn.get_info()["ipv4"]["addresses"], ["192.0.2.10"])
|