mirror of
https://github.com/retspen/webvirtcloud
synced 2026-11-08 19:26:48 +00:00
10b46afd36
libvirt has no timeout for opening a connection. Measured in the test setup: an unreachable host blocked qemu+tcp for 135 s and qemu+ssh for 133 s; a daemon that accepts and never answers blocks forever. Gunicorn runs sync workers and the instance list connects to every compute, so one unreachable compute held a worker for minutes per page load. - A connection is opened in a helper thread, at most one per connection at a time. The request waits LIBVIRT_CONNECT_TIMEOUT (default 5 s). An open nobody waits for any more keeps running; until it ends, requests get its error at once, and if it succeeds later the connection is used. A failed open is not repeated for LIBVIRT_RETRY_AFTER (default 30 s). A stuck host holds one thread and does not keep other hosts from connecting. - qemu+ssh runs ssh through vrtManager/libvirt-ssh (the URI's command parameter), which adds ConnectTimeout=10 and BatchMode=yes, so an abandoned ssh process ends and no prompt can hang. The user's ssh configuration (aliases, ProxyJump, keys) still applies. - The close callback acts only for the connection it was registered for: a late callback of a replaced connection dropped its successor. The reason is reported as text. A connection that closed before it was published is an error. - Compute.status is a bool (it returned the exception object, so the "host is down" check in refresh_instance_database never fired); the message is Compute.connection_error. Unit tests cover the timeout, retry delay, late success, single open, a stuck host next to a healthy one and the close callback. Live tests (vrtManager/test_live_connection.py), for TCP and SSH computes of the test setup: an unreachable address (no ssh left after 10 s), an endpoint that never answers, a slow open completing later, a host that goes silent on an established connection (keepalive ends calls within 45 s, the next request reconnects), an ssh_config alias and a ProxyJump host. |
||
|---|---|---|
| .. | ||
| api | ||
| fixtures | ||
| migrations | ||
| templates | ||
| templatetags | ||
| __init__.py | ||
| apps.py | ||
| forms.py | ||
| livetest.py | ||
| models.py | ||
| test_change_network.py | ||
| test_change_xml.py | ||
| test_clone_permission.py | ||
| test_console_rule.py | ||
| test_console_settings_access.py | ||
| test_create_instance.py | ||
| test_create_rollback.py | ||
| test_destroy.py | ||
| test_disk_isolation.py | ||
| test_error_handling.py | ||
| test_gstfsd.py | ||
| test_index.py | ||
| test_live_clone.py | ||
| test_live_create.py | ||
| test_live_dataloss.py | ||
| test_live_guest.py | ||
| test_live_iso.py | ||
| test_live_xml.py | ||
| test_live_xml_effects.py | ||
| test_quota_lock.py | ||
| test_root_pass.py | ||
| test_security_mutations.py | ||
| test_template_flag.py | ||
| test_update_console.py | ||
| test_xss.py | ||
| tests.py | ||
| urls.py | ||
| utils.py | ||
| views.py | ||