mirror of
https://github.com/retspen/webvirtcloud
synced 2026-11-08 19:26:48 +00:00
dba41f97f3
When the server refused a VM create submission (a field error, a busy resource, a reused submission key, an existing VM name, a missing MAC for a new disk), the page came back on its first tab with the flavor dialog closed and every entered value gone: the hand-written fields showed fixed defaults, and the errors sat in a block at the top of the page, outside #messages and tied to no field. The view builds one NewVMForm per create form on the page (custom, template, one per flavor; create_forms), each with its own defaults; a hidden form_id, which is also the prefix of the form's field ids, names the submitted one, and it comes back bound. Every field renders from its own form and is marked by two small template tags (form_fields: error_attrs, field_error) when refused; a summary at the top of the form lists all of its errors, also those of fields it keeps hidden. The submitted tab or flavor dialog, marked data-form-id, reopens with any "Advanced" section that holds an error; a reopened dialog shows the messages too; the template form gets its pool, template and storage back. base.html's error focus is a function that walks the places an error can be, and a page can call it once it is set up, as the create page does. form_id changes nothing in how a POST is processed; one of an unknown form (a flavor deleted since) has its errors in the messages. The default video now applies to every create form. The custom form's disks and networks are not restored yet.
29 lines
1.3 KiB
Python
29 lines
1.3 KiB
Python
"""The VM create page rendered on libvirt's test driver, for the tests of
|
|
that page."""
|
|
|
|
from unittest.mock import patch
|
|
|
|
import libvirt
|
|
from computes.models import Compute
|
|
from django.contrib.auth import get_user_model
|
|
from django.urls import reverse
|
|
|
|
|
|
def render_create_page(testcase, data=None):
|
|
"""GET the create page, or POST data (a create submission) to it, as a
|
|
superuser on a test-driver compute; returns (compute, response)."""
|
|
conn = libvirt.open("test:///default")
|
|
testcase.addCleanup(conn.close)
|
|
compute, _ = Compute.objects.get_or_create(name="testdrv", hostname="localhost", login="", password="", type=4)
|
|
user = get_user_model().objects.filter(username="page").first() or \
|
|
get_user_model().objects.create_superuser("page", "page@example.com", "pw")
|
|
testcase.client.force_login(user)
|
|
url = reverse("instances:create_instance", args=[compute.id, "i686", "pc"])
|
|
with patch("vrtManager.connection.connection_manager.get_connection", return_value=conn), \
|
|
patch("vrtManager.connection.wvmConnect.get_machine_types", return_value=["pc"]), \
|
|
patch("vrtManager.connection.wvmConnect.get_nwfilters", return_value=[]):
|
|
if data is None:
|
|
response = testcase.client.get(url)
|
|
else:
|
|
response = testcase.client.post(url, {"create": "", **data})
|
|
return compute, response
|