mirror of
https://github.com/retspen/webvirtcloud
synced 2026-11-08 11:16:47 +00:00
3e427a41b8
Instance.proxy looked the domain up by its stored name. After a rename or a name swap outside WebVirtCloud, an operation on one VM changed another; after a VM was replaced under the same name, operations hit the new VM. wvmInstance takes the UUID and uses lookupByUUIDString, with no fallback to the name: a missing UUID fails instead of picking another domain. Every caller that has an Instance passes it: proxy, console, quota, post-migration autostart and the VDI URL. Migration uses the domain the proxy already resolved. getvvfile and the gstfsd requests use the host's current name of that UUID. Live tests cover a name swap and a VM replaced under the same name; both fail on the previous code.
75 lines
3.4 KiB
Python
75 lines
3.4 KiB
Python
"""
|
|
ROADMAP Wave 0 item 5 (S-09): one rule decides who may open a VM's console
|
|
(noVNC page, novncd, the virt-viewer .vv file, the VDI URL): a superuser or
|
|
an owner of the VM. The global view_instances permission is read-only.
|
|
"""
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from django.contrib.auth import get_user_model
|
|
from django.contrib.auth.models import Permission
|
|
from django.test import TestCase
|
|
from django.urls import reverse
|
|
|
|
from accounts.models import UserInstance
|
|
from computes.models import Compute
|
|
from instances.models import Instance
|
|
from instances.utils import can_open_console
|
|
|
|
|
|
class CanOpenConsoleTestCase(TestCase):
|
|
def setUp(self):
|
|
User = get_user_model()
|
|
self.superuser = User.objects.create_superuser(
|
|
username="cons_super", email="cons_super@example.com", password="x"
|
|
)
|
|
self.owner = User.objects.create_user(username="cons_owner", password="x")
|
|
self.inactive_owner = User.objects.create_user(
|
|
username="cons_inactive", password="x", is_active=False
|
|
)
|
|
self.viewer = User.objects.create_user(username="cons_viewer", password="x")
|
|
self.viewer.user_permissions.add(Permission.objects.get(codename="view_instances"))
|
|
self.stranger = User.objects.create_user(username="cons_stranger", password="x")
|
|
|
|
self.compute = Compute.objects.create(
|
|
name="cons-compute", hostname="127.0.0.1:1", login="root", password="", type=1
|
|
)
|
|
self.instance = Instance.objects.create(
|
|
compute=self.compute,
|
|
name="cons-vm",
|
|
uuid="77777777-8888-9999-aaaa-bbbbbbbbbbbb",
|
|
)
|
|
UserInstance.objects.create(instance=self.instance, user=self.owner)
|
|
UserInstance.objects.create(instance=self.instance, user=self.inactive_owner)
|
|
|
|
def test_superuser_and_owner_may_open_console(self):
|
|
self.assertTrue(can_open_console(self.superuser, self.instance))
|
|
self.assertTrue(can_open_console(self.owner, self.instance))
|
|
|
|
def test_view_instances_stranger_and_inactive_owner_may_not(self):
|
|
self.assertFalse(can_open_console(self.viewer, self.instance))
|
|
self.assertFalse(can_open_console(self.stranger, self.instance))
|
|
self.assertFalse(can_open_console(self.inactive_owner, self.instance))
|
|
|
|
def test_owner_can_download_vv_file(self):
|
|
self.client.force_login(self.owner)
|
|
with patch("instances.views.wvmInstances") as mock_conn_cls, patch("instances.models.wvmInstance") as wvm:
|
|
wvm.return_value.instance.name.return_value = "cons-vm"
|
|
conn = mock_conn_cls.return_value
|
|
conn.graphics_type.return_value = "vnc"
|
|
conn.graphics_listen.return_value = "127.0.0.1"
|
|
conn.graphics_port.return_value = "5900"
|
|
conn.domain_name.return_value = "cons-vm"
|
|
conn.graphics_passwd.return_value = "secret"
|
|
res = self.client.get(reverse("instances:getvvfile", args=[self.instance.id]))
|
|
self.assertEqual(res.status_code, 200)
|
|
self.assertIn(b"[virt-viewer]", res.content)
|
|
|
|
def test_owner_can_get_vdi_url(self):
|
|
self.client.force_login(self.owner)
|
|
with patch("datasource.views.wvmInstance", MagicMock()), patch(
|
|
"datasource.views.get_hostname_by_ip", return_value="host"
|
|
):
|
|
res = self.client.get(
|
|
reverse("vdi_url", args=[self.compute.id, self.instance.name])
|
|
)
|
|
self.assertEqual(res.status_code, 200)
|