mirror of
https://github.com/retspen/webvirtcloud
synced 2026-11-08 19:26:48 +00:00
084f2e8b60
The usage list of the create-secret dialog came from the map that names the usage types of existing secrets, so it offered none and tls too; the form takes ceph, volume and iscsi only, and picking none or tls always failed with "Select a valid choice". The dialog now lists the form's own choices.
63 lines
3.1 KiB
Python
63 lines
3.1 KiB
Python
"""A secret's usage value goes into its XML as text, whatever it holds: a
|
|
volume path, an iSCSI IQN or a Ceph name, and characters XML gives a meaning."""
|
|
|
|
from unittest.mock import patch
|
|
|
|
from computes.models import Compute
|
|
from django.contrib.auth import get_user_model
|
|
from django.test import SimpleTestCase, TestCase
|
|
from django.urls import reverse
|
|
from lxml import etree, html
|
|
from virtsecrets.forms import AddSecret
|
|
from vrtManager.virtsecrets import wvmSecrets
|
|
|
|
|
|
class CreateSecretTests(SimpleTestCase):
|
|
def defined_xml(self, usage_type, data):
|
|
with patch("vrtManager.connection.connection_manager.get_connection") as get:
|
|
wvmSecrets("host", "login", "pw", 1).create_secret("no", "yes", usage_type, data)
|
|
return etree.fromstring(get.return_value.secretDefineXML.call_args.args[0])
|
|
|
|
def test_the_usage_value_is_text_of_its_element(self):
|
|
for usage_type, element, data in (
|
|
("volume", "volume", "/var/lib/libvirt/images/vm-1.qcow2"),
|
|
("iscsi", "target", "iqn.2026-10.test.wvc:lun"),
|
|
("ceph", "name", "client.libvirt secret"),
|
|
("volume", "volume", "/a'b<c>&d\""),
|
|
):
|
|
with self.subTest(usage_type=usage_type, data=data):
|
|
secret = self.defined_xml(usage_type, data)
|
|
self.assertEqual((secret.get("ephemeral"), secret.get("private")), ("no", "yes"))
|
|
self.assertEqual(secret.find("usage").get("type"), usage_type)
|
|
self.assertEqual(secret.findtext(f"usage/{element}"), data)
|
|
|
|
|
|
class SecretValueTests(SimpleTestCase):
|
|
def secrets(self):
|
|
with patch("vrtManager.connection.connection_manager.get_connection") as get:
|
|
conn = wvmSecrets("host", "login", "pw", 1)
|
|
secret = get.return_value.secretLookupByUUIDString.return_value
|
|
return conn, secret
|
|
|
|
def test_a_base64_value_is_stored_as_its_bytes(self):
|
|
conn, secret = self.secrets()
|
|
conn.set_secret_value("uuid", "cHcA/w==")
|
|
secret.setValue.assert_called_once_with(b"pw\x00\xff")
|
|
|
|
def test_a_value_that_is_not_base64_is_refused(self):
|
|
conn, secret = self.secrets()
|
|
for value in ("b'cHc='", "not base64!"):
|
|
with self.subTest(value=value), self.assertRaises(ValueError):
|
|
conn.set_secret_value("uuid", value)
|
|
secret.setValue.assert_not_called()
|
|
|
|
|
|
class CreateSecretDialogTests(TestCase):
|
|
def test_the_dialog_offers_the_usage_types_the_form_takes(self):
|
|
compute = Compute.objects.create(name="secret-usage", hostname="localhost", login="", password="", type=4)
|
|
self.client.force_login(get_user_model().objects.create_superuser("usage", "usage@example.com", "pw"))
|
|
with patch("virtsecrets.views.wvmSecrets") as conn:
|
|
conn.return_value.get_secrets.return_value = []
|
|
response = self.client.get(reverse("virtsecrets", args=[compute.id]))
|
|
offered = html.fromstring(response.content).xpath("//select[@id='secret_usage_type']/option/@value")
|
|
self.assertEqual(offered, [value for value, _ in AddSecret.base_fields["usage_type"].choices])
|