mirror of
https://github.com/retspen/webvirtcloud
synced 2026-11-08 19:26:48 +00:00
8d7f28482f
- A VM delete reads delete_disk and delete_nvram as booleans from a JSON
or form body. The view read them as HTML checkboxes from the form body
only: JSON {"delete_disk": true} kept the disks while reporting success,
and a form "delete_disk=false" deleted them. Refused options stop
nothing; the API schema names both options.
- Power on and power cycle of a template answer 409 instead of reporting a
start that did not happen.
- The VM details leave out the host's ISO images for non-superusers, as
the VM page does; reading them also refreshed every pool of the host.
- Flavors take values of at least 1, as the web form does, and show their
id for later changes; a migration needs neither live nor offline; a VM
create on an unknown compute answers 404 instead of 500.
133 lines
4 KiB
Python
133 lines
4 KiB
Python
from instances.models import CreateInstance, Flavor, Instance, MigrateInstance
|
|
from instances.utils import nic_macs
|
|
from rest_framework import serializers
|
|
|
|
|
|
class InstanceSerializer(serializers.ModelSerializer):
|
|
class Meta:
|
|
model = Instance
|
|
fields = ["id", "compute", "name", "uuid", "is_template", "created", "drbd"]
|
|
|
|
|
|
class InstanceDetailsSerializer(serializers.ModelSerializer):
|
|
def get_fields(self):
|
|
fields = super().get_fields()
|
|
# the host's ISO images are a superuser's, as on the VM page; reading
|
|
# them refreshes every pool of the host
|
|
request = self.context.get("request")
|
|
if not (request and request.user.is_superuser):
|
|
del fields["media_iso"]
|
|
return fields
|
|
|
|
class Meta:
|
|
model = Instance
|
|
fields = [
|
|
"id",
|
|
"compute",
|
|
"status",
|
|
"uuid",
|
|
"name",
|
|
"title",
|
|
"description",
|
|
"is_template",
|
|
"created",
|
|
"drbd",
|
|
"arch",
|
|
"machine",
|
|
"vcpu",
|
|
"memory",
|
|
"firmware",
|
|
"nvram",
|
|
"bootmenu",
|
|
"boot_order",
|
|
"disks",
|
|
"media",
|
|
"media_iso",
|
|
"snapshots",
|
|
"networks",
|
|
"console_type",
|
|
"console_port",
|
|
"console_keymap",
|
|
"console_listener_address",
|
|
"video_model",
|
|
"guest_agent_ready",
|
|
"autostart",
|
|
]
|
|
|
|
|
|
class FlavorSerializer(serializers.ModelSerializer):
|
|
class Meta:
|
|
model = Flavor
|
|
fields = ["id", "label", "memory", "vcpu", "disk"]
|
|
# as the web form (instances.forms.FlavorForm): MiB, vCPUs and GiB, each at least 1
|
|
extra_kwargs = {"memory": {"min_value": 1}, "vcpu": {"min_value": 1}, "disk": {"min_value": 1}}
|
|
|
|
|
|
class DestroyOptionsSerializer(serializers.Serializer):
|
|
"""What a VM's delete takes besides the VM: from the web form's checkboxes
|
|
or an API body, JSON or form-encoded ("false" is false)."""
|
|
|
|
delete_disk = serializers.BooleanField(default=False)
|
|
delete_nvram = serializers.BooleanField(default=False)
|
|
|
|
|
|
class CreateInstanceSerializer(serializers.ModelSerializer):
|
|
video = serializers.CharField(initial="vga")
|
|
storage = serializers.CharField(initial="default")
|
|
cache_mode = serializers.CharField(initial="none")
|
|
virtio = serializers.BooleanField(initial=True)
|
|
qemu_ga = serializers.BooleanField(initial=True)
|
|
submission_key = serializers.CharField(write_only=True)
|
|
|
|
def validate(self, attrs):
|
|
try:
|
|
nic_macs(attrs.get("mac"), attrs.get("networks", ""))
|
|
except ValueError as err:
|
|
raise serializers.ValidationError({"mac": str(err)})
|
|
return attrs
|
|
|
|
class Meta:
|
|
model = CreateInstance
|
|
fields = [
|
|
"name",
|
|
"vcpu",
|
|
"vcpu_mode",
|
|
"memory",
|
|
"networks",
|
|
"mac",
|
|
"nwfilter",
|
|
"storage",
|
|
"hdd_size",
|
|
"cache_mode",
|
|
"meta_prealloc",
|
|
"virtio",
|
|
"qemu_ga",
|
|
"cloud_init",
|
|
"video",
|
|
"listener_addr",
|
|
"submission_key",
|
|
]
|
|
|
|
|
|
class MigrateSerializer(serializers.ModelSerializer):
|
|
instance = Instance.objects.all().prefetch_related("userinstance_set")
|
|
live = serializers.BooleanField(default=True)
|
|
offline = serializers.BooleanField(default=False)
|
|
# left out, also from a form-encoded request: auto converge on
|
|
autoconverge = serializers.BooleanField(default=True)
|
|
compress = serializers.BooleanField(default=False)
|
|
unsafe = serializers.BooleanField(default=False)
|
|
submission_key = serializers.CharField(write_only=True)
|
|
|
|
class Meta:
|
|
model = MigrateInstance
|
|
fields = [
|
|
"instance",
|
|
"target_compute",
|
|
"live",
|
|
"offline",
|
|
"autoconverge",
|
|
"compress",
|
|
"unsafe",
|
|
"submission_key",
|
|
]
|