1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud synced 2026-11-09 11:46:49 +00:00

chore: drop references to the local roadmap from code and tests

Comments, docstrings and live test names cited item IDs of a roadmap
that is not part of the repository. They now say what is meant, or
nothing where the sentence stands without them. Test assertions and
behavior are unchanged.
This commit is contained in:
catborise 2026-10-04 11:09:25 +03:00
parent 39feb373ed
commit f94b3cee7a
37 changed files with 87 additions and 89 deletions

View file

@ -51,7 +51,7 @@ from vrtManager.storage import wvmStorage, wvmStorages
# Edits that redefine the domain start from this: the persistent definition,
# with secrets. Live XML would drop pending changes, non-secure XML the VNC
# password (R-01, R-02).
# password.
PERSISTENT_XML = VIR_DOMAIN_XML_INACTIVE | VIR_DOMAIN_XML_SECURE
@ -711,7 +711,7 @@ class wvmInstance(wvmConnect):
"""Insert path into, or with None eject, CD-ROM dev.
The live and the persistent definition are updated separately from
their own device XML, so neither is rewritten from the other (R-12).
their own device XML, so neither is rewritten from the other.
"""
definitions = [("persistent", PERSISTENT_XML, VIR_DOMAIN_AFFECT_CONFIG)]
if self.instance.isActive(): # running or paused
@ -1338,7 +1338,7 @@ class wvmInstance(wvmConnect):
time.time(),
)
# libvirt decides whether this firmware/NVRAM supports internal
# snapshots; the domain definition is never rewritten for it (R-13).
# snapshots; the domain definition is never rewritten for it.
xml += self._XMLDesc(VIR_DOMAIN_XML_SECURE)
xml += """<active>0</active>
</domainsnapshot>"""
@ -1506,7 +1506,7 @@ class wvmInstance(wvmConnect):
def clone_instance(self, clone_data):
"""Copy a shut-off VM. Inputs are checked before anything is allocated,
and on failure only the volumes this call created are removed (R-08)."""
and on failure only the volumes this call created are removed."""
if self.get_status() != 5:
# A running guest keeps writing while its disks are copied.
raise util.OperationError("Shut the VM down before cloning it")

View file

@ -41,7 +41,7 @@ class TestChangeNetwork(unittest.TestCase):
self.assertEqual(second.find("source").attrib, {"bridge": "br0"})
self.assertEqual(second.find("model").get("type"), "e1000")
self.assertEqual(second.find("filterref").get("filter"), "clean-traffic")
# F-06: QoS, link state and the PCI address survive
# QoS, link state and the PCI address survive
self.assertEqual(second.find("bandwidth/outbound").get("average"), "1000")
self.assertEqual(second.find("link").get("state"), "down")
self.assertEqual(second.find("address").get("bus"), "0x02")

View file

@ -1,4 +1,4 @@
"""R-09: reachability probe and connections that do not block each other."""
"""Reachability probe and connections that do not block each other."""
import socket
import threading

View file

@ -25,7 +25,7 @@ def vm(active):
class IsoMediaTestCase(unittest.TestCase):
"""R-12: media change goes through updateDeviceFlags for the right CD-ROM."""
"""Media change goes through updateDeviceFlags for the right CD-ROM."""
def updates(self, inst):
return [

View file

@ -16,7 +16,7 @@ DOMAIN = """<domain><name>vm</name><memory>131072</memory><currentMemory>131072<
class PersistentEditsTestCase(unittest.TestCase):
"""R-01/R-02: edits read the persistent definition with secrets."""
"""Edits read the persistent definition with secrets."""
def test_edits_read_the_persistent_secure_definition(self):
edits = {

View file

@ -170,7 +170,7 @@ class TestXmlSafety(unittest.TestCase):
inst._defineXML.assert_not_called()
def test_internal_snapshot_never_rewrites_a_pflash_loader(self):
# R-13: libvirt decides; the definition is not switched to rom.
# libvirt decides; the definition is not switched to rom.
inst = wvmInstance.__new__(wvmInstance)
inst.get_status = MagicMock(return_value=5)
inst._XMLDesc = MagicMock(
@ -187,7 +187,7 @@ class TestXmlSafety(unittest.TestCase):
class TestCloneRollback(unittest.TestCase):
"""R-08: a failed clone removes only the volumes it created."""
"""A failed clone removes only the volumes it created."""
def test_copies_are_removed_when_the_definition_fails(self):
import libvirt