mirror of
https://github.com/retspen/webvirtcloud
synced 2026-11-09 03:36:48 +00:00
chore: drop references to the local roadmap from code and tests
Comments, docstrings and live test names cited item IDs of a roadmap that is not part of the repository. They now say what is meant, or nothing where the sentence stands without them. Test assertions and behavior are unchanged.
This commit is contained in:
parent
39feb373ed
commit
f94b3cee7a
37 changed files with 87 additions and 89 deletions
|
|
@ -19,7 +19,7 @@ django.setup()
|
|||
|
||||
from django.conf import settings as django_settings
|
||||
|
||||
# socketiod does not authenticate connections yet (ROADMAP S-01): any client
|
||||
# socketiod does not authenticate connections yet: any client
|
||||
# that can reach the port can read and write an open serial console. Refuse
|
||||
# to start unless an admin explicitly opts in.
|
||||
if not getattr(django_settings, "SERIAL_CONSOLE_ENABLED", False):
|
||||
|
|
|
|||
|
|
@ -11,7 +11,7 @@ SOCKETIOD = ROOT / "console" / "socketiod"
|
|||
|
||||
|
||||
class SocketiodDisabledTestCase(unittest.TestCase):
|
||||
"""ROADMAP S-01: socketiod must refuse to start unless explicitly enabled."""
|
||||
"""socketiod must refuse to start unless explicitly enabled."""
|
||||
|
||||
def test_socketiod_exits_when_serial_console_disabled(self):
|
||||
# The settings module lives in a temporary directory, so the test does
|
||||
|
|
|
|||
|
|
@ -140,7 +140,7 @@ class ConsoleViewsTestCase(TestCase):
|
|||
@override_settings(SERIAL_CONSOLE_ENABLED=False)
|
||||
@patch("console.views.wvmInstance")
|
||||
def test_console_pty_refused_when_serial_console_disabled(self, mock_wvm):
|
||||
# ROADMAP S-01: socketiod is unauthenticated, so the serial console is
|
||||
# socketiod is unauthenticated, so the serial console is
|
||||
# disabled unless an admin explicitly enables it.
|
||||
mock_conn = MagicMock()
|
||||
mock_conn.get_console_type.return_value = "pty"
|
||||
|
|
@ -194,7 +194,7 @@ class ConsoleViewsTestCase(TestCase):
|
|||
|
||||
@patch("console.views.wvmInstance")
|
||||
def test_console_token_cookie_flags(self, mock_wvm):
|
||||
# ROADMAP S-11: the token cookie is only read by novncd, never by JS.
|
||||
# The token cookie is only read by novncd, never by JS.
|
||||
mock_conn = MagicMock()
|
||||
mock_conn.get_console_type.return_value = "vnc"
|
||||
mock_conn.get_console_websocket_port.return_value = None
|
||||
|
|
@ -209,7 +209,7 @@ class ConsoleViewsTestCase(TestCase):
|
|||
|
||||
@patch("console.views.wvmInstance")
|
||||
def test_console_view_instances_perm_does_not_open_console(self, mock_wvm):
|
||||
# ROADMAP S-09: global view_instances is a read-only role; the console
|
||||
# Global view_instances is a read-only role; the console
|
||||
# is for superusers and VM owners only.
|
||||
mock_conn = MagicMock()
|
||||
mock_conn.get_console_type.return_value = "vnc"
|
||||
|
|
|
|||
|
|
@ -129,7 +129,7 @@ def console(request):
|
|||
elif console_type == "pty" and not getattr(
|
||||
settings, "SERIAL_CONSOLE_ENABLED", False
|
||||
):
|
||||
# socketiod does not authenticate connections yet (ROADMAP S-01), so
|
||||
# socketiod does not authenticate connections yet, so
|
||||
# the serial console stays off unless an admin explicitly enables it.
|
||||
console_error = _(
|
||||
"Serial console is disabled on this server. "
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue