j3d1/webvirtcloud
1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud synced 2026-11-10 20:26:48 +00:00
Code Issues Projects Releases Wiki Activity

fix(virtsecrets): saving a secret's value unchanged keeps it

Browse source 
get_secret_value returned bytes, so the edit dialog showed b'cHc=' (the
bytes' repr) for the base64 value cHc=. Saving the dialog as shown fed
"b'cHc='" to b64decode, which dropped the quotes and the b and stored
other bytes: the secret silently changed (pw became m\xc1\xdc). The value
is now base64 text, and set_secret_value decodes with validate=True, so
a value that is not base64 is refused with a message instead. The field
had an invalid pattern ([a-zA-Z0-9]$+, ignored by browsers) and a 45
character limit; it takes base64 of any length.
This commit is contained in:
catborise 2026-10-19 20:56:56 +03:00
parent eb828b364d
commit f4cdd91210
3 changed files with 28 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
vrtManager/virtsecrets.py
View file

@ -16,14 +16,14 @@ class wvmSecrets(wvmConnect):
self.wvm.secretDefineXML(etree.tostring(secret, encoding="unicode"))
def get_secret_value(self, uuid):
"""The value as base64 text, the form set_secret_value takes."""
secrt = self.get_secret(uuid)
value = secrt.value()
return base64.b64encode(value)
return base64.b64encode(secrt.value()).decode()
def set_secret_value(self, uuid, value):
secrt = self.get_secret(uuid)
value = base64.b64decode(value)
secrt.setValue(value)
# validate: a value that is not base64 is refused, not decoded to other bytes
secrt.setValue(base64.b64decode(value, validate=True))
def delete_secret(self, uuid):
secrt = self.get_secret(uuid)