j3d1/webvirtcloud
1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud synced 2026-11-08 11:16:47 +00:00
Code Issues Projects Releases Wiki Activity

fix(instances): a VM list poll for a host id that is not a number is 404

Browse source 
instances:states?compute=x raised ValueError in the lookup, a 500.
This commit is contained in:
catborise 2026-11-06 11:01:58 +03:00
parent afe80a9e78
commit f3bdeddb0b
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
instances/tests/test_vm_states.py
View file

@ -54,6 +54,9 @@ class VmStatesTestCase(TestCase):
stranger = get_user_model().objects.create_user("st-stranger", password="pw")
self.assertEqual(self.get(stranger).json()["computes"], {})
def test_a_host_id_that_is_not_a_number_is_not_found(self):
self.assertEqual(self.get(self.admin, "?compute=x").status_code, 404)
def test_one_host_s_list_is_for_administrators(self):
self.assertEqual(self.get(self.admin, f"?compute={self.up.pk}").json()["computes"],
{str(self.up.pk): {"ok": True, "vms": UP}})

6
instances/views.py
View file

@ -126,10 +126,12 @@ def states(request):
"""The VM lists' poll: utils.vm_states of the list's hosts; ?compute=id
for one host's list (administrators)."""
computes = list(Compute.objects.all())
if request.GET.get("compute"):
if compute := request.GET.get("compute"):
if not request.user.is_superuser:
raise PermissionDenied
computes = [get_object_or_404(Compute, pk=request.GET["compute"])]
if not compute.isdigit():
raise Http404
computes = [get_object_or_404(Compute, pk=compute)]
response = JsonResponse({"computes": utils.vm_states(request.user, _listed_computes(request.user, computes))})
response["Cache-Control"] = "no-store"
return response