1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud synced 2026-11-10 04:06:47 +00:00

test: no seeded admin password, settings changed only for a test, no local libvirt by default

- create_admin had a branch for `"test" in sys.argv` that gave the admin
  the password "admin"; 17 places signed in with it, and failed silently
  with ADMIN_PASSWORD set in the environment. The tests now make their
  own superuser and force_login it, and the shipped code has no test
  branch: the test runner gives migrate a password (also when
  ADMIN_PASSWORD is set but empty), so no data/admin_password is written
  into the checkout.
- AccountsTestCase builds its rows in setUpTestData instead of
  setUpClass and deleting them by hand.
- accounts tests set OTP_ENABLED with override_settings instead of
  assigning settings (one assignment was never undone, so later tests in
  the process ran with OTP on), and undo their app_settings change. The
  OTP login class reloads the URLs again only after the setting is off.
- computes/tests/test_views.py reached the machine's own libvirt
  (localhost over the socket) when TEST_LIBVIRT_HOST was unset; its live
  tests now run only with TEST_LIBVIRT_HOST, like the other live tests,
  as the README says.
This commit is contained in:
catborise 2026-11-06 11:17:59 +03:00
parent a4ea23004f
commit ee6b8d3e10
12 changed files with 67 additions and 74 deletions

View file

@ -1,9 +1,10 @@
import json
import os
from unittest.mock import patch
from django.contrib.auth import get_user_model
from django.core.exceptions import ObjectDoesNotExist
from django.shortcuts import reverse
from django.test import RequestFactory, TestCase, TransactionTestCase
from django.test import TestCase, TransactionTestCase
from vrtManager.connection import CONN_SOCKET, connection_manager
from computes.models import Compute
@ -17,7 +18,8 @@ TEST_COMPUTE_TYPE = int(os.environ.get("TEST_LIBVIRT_TYPE", CONN_SOCKET))
class ComputesTestCase(TestCase):
def setUp(self):
self.client.login(request=RequestFactory().get("/"), username="admin", password="admin")
self.admin = get_user_model().objects.create_superuser("tests-admin", "admin@example.com", "pw")
self.client.force_login(self.admin)
self.compute, _ = Compute.objects.get_or_create(
name="computes-test-compute",
defaults={
@ -34,6 +36,8 @@ class ComputesTestCase(TestCase):
super().tearDown()
def _require_live_compute(self):
if not livetest.enabled(): # never the machine's own libvirt by default
self.skipTest("Set TEST_LIBVIRT_HOST to run the live libvirt tests")
try:
conn = connection_manager.get_connection(
self.compute.hostname,