j3d1/webvirtcloud
1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud synced 2026-11-11 12:46:49 +00:00
Code Issues Projects Releases Wiki Activity

fix(instances): a clone's MAC address is not the VM's or another of its NICs'

Browse source 
The addresses were checked for their form only: a clone could keep the
VM's address, or give two NICs one, and the NICs on a network then take
each other's traffic. Such an address is refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Kk4h2TcUiaWmU5MUszYSea
This commit is contained in:
catborise 2026-11-07 23:44:22 +03:00
parent 41ef48f2e0
commit d49db11e78
6 changed files with 182 additions and 154 deletions
Download patch file Download diff file Expand all files Collapse all files

9
instances/tests/test_clone_job.py
View file

@ -340,6 +340,15 @@ class LiveCloneJobTestCase(TransactionTestCase):
CloneInstance().plan(self.admin, {"instance": self.source.pk, "fields": {
"name": name, "disk-vda": "copy.qcow2", "clone-net-mac-0": "52:54:00:00:00:01"}})
def test_a_mac_of_the_vm_or_of_another_nic_of_the_clone_is_refused(self):
for macs in (["52:54:00:AA:BB:CC"], ["52:54:00:00:00:01", "525400000001"]):
with self.subTest(macs=macs):
self.proxy.get_net_devices.return_value = [{"mac": "52:54:00:aa:bb:cc"}, {"mac": "52:54:00:aa:bb:cd"}]
fields = {"name": "copy", "disk-vda": "copy.qcow2", "clone-net-mac-1": "52:54:00:00:00:09",
**{f"clone-net-mac-{n}": mac for n, mac in enumerate(macs)}}
with self.assertRaisesMessage(OperationError, "is the VM's or another NIC's of the clone"):
CloneInstance().plan(self.admin, {"instance": self.source.pk, "fields": fields})
def test_another_state_is_refused(self):
self.proxy.get_status.return_value = 4 # shutting down
with self.assertRaisesMessage(OperationError, "The VM must be running, paused or shut off to be cloned"):