j3d1/webvirtcloud
1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud synced 2026-11-11 12:46:49 +00:00
Code Issues Projects Releases Wiki Activity

fix(jobs): migration recovery shuts off a shut-off VM the migration left started

Browse source 
A shut-off VM with a TPM or disks to copy migrates started paused
(migrate_running), and the job shuts it off afterwards on whichever host
has it. A worker that stopped in between left it running paused, on the
source when the migration did not happen or on the destination when it
did; recovery reported the outcome but left the VM running. The job now
records whether the VM was shut off, and recovery destroys it again
where it ended up.
This commit is contained in:
catborise 2026-11-06 08:59:37 +03:00
parent e3e32f6b90
commit c3dfab287d
2 changed files with 31 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

21
instances/tests/test_migrate_job.py
View file

@ -79,6 +79,27 @@ class MigrateJobTestCase(TransactionTestCase):
self.vm.refresh_from_db()
self.assertEqual(self.vm.compute, self.dest)
def test_recovery_shuts_off_a_shut_off_vm_the_migration_left_started(self):
self.vm.proxy.get_status.return_value = 5
op = self.queue()
ctx = self.start(op)
self.dest_conn.moveto.side_effect = OSError("the worker stops here")
with self.assertRaises(OSError):
get_kind(op.kind).run(op, ctx)
self.assertTrue(op.intent["shut_off"])
dom = MagicMock()
dom.isActive.return_value = True
dom.jobInfo.return_value = [0] * 12 # VIR_DOMAIN_JOB_NONE
for found in ([dom, None], [None, dom]): # stayed on the source, or moved
with self.subTest(found=found), patch("instances.jobs._domain", side_effect=found):
MigrateInstance().reconcile(op)
dom.destroy.assert_called_once_with()
dom.destroy.reset_mock()
op.intent["shut_off"] = False # a running VM keeps running
with patch("instances.jobs._domain", side_effect=[dom, None]):
MigrateInstance().reconcile(op)
dom.destroy.assert_not_called()
def test_a_copy_claims_its_volume_on_both_computes(self):
Instance.proxy.get_disk_devices.return_value = [
{"dev": "vda", "storage": "default", "image": "mig-vm.qcow2", "path": "/i/mig-vm.qcow2"},