j3d1/webvirtcloud
1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud synced 2026-11-11 12:46:49 +00:00
Code Issues Projects Releases Wiki Activity

fix(migrate): a disk of an LVM or disk pool does not count as shared with the destination

Browse source 
Each host's logical volumes are its own: a VM whose disk is /dev/vg/x
migrated, uncopied, onto the destination's volume of the same name and
kept running on other data. Such a volume now counts as missing there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Kk4h2TcUiaWmU5MUszYSea
This commit is contained in:
catborise 2026-11-07 22:39:26 +03:00
parent eb0343ee2f
commit c2c255a866
3 changed files with 24 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
vrtManager/tests/test_migration.py
View file

@ -246,6 +246,18 @@ class DestinationDisksTestCase(unittest.TestCase):
with self.assertRaisesRegex(util.OperationError, "vdb \\(dir disk, cannot be checked\\)"):
self.migrate(FakeHost(), xml, state=5)
def test_a_volume_of_a_host_s_own_lvm_or_disk_pool_is_missing(self):
# another host's logical volume of the same name is other data
for pool_type in ("logical", "disk"):
with self.subTest(pool_type=pool_type):
host = FakeHost(volumes={"/dev/vg/vm"}, pool_types={"/dev/vg/vm": pool_type})
xml = with_disks("<disk type='block' device='disk'><source dev='/dev/vg/vm'/><target dev='vda'/></disk>")
with self.assertRaisesRegex(util.OperationError, "vda \\(/dev/vg/vm\\)"):
self.migrate(host, xml)
host = FakeHost(volumes={"/dev/sdz"}, pool_types={"/dev/sdz": "iscsi"})
xml = with_disks("<disk type='block' device='disk'><source dev='/dev/sdz'/><target dev='vda'/></disk>")
self.assertEqual(len(self.migrate(host, xml).instance.calls), 1)
def test_a_volume_of_an_inactive_pool_is_missing(self):
host = FakeHost(volumes={"v"}, inactive_pools={"p"})
xml = with_disks("<disk type='volume' device='disk'><source pool='p' volume='v'/><target dev='vdc'/></disk>")