j3d1/webvirtcloud
1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud synced 2026-11-10 20:26:48 +00:00
Code Issues Projects Releases Wiki Activity

perf(computes): a host's capacity is one libvirt call, not one per VM

Browse source 
The Computes page, the host overview and the new-VM dialog's capacity line
read each VM's XML for its memory and vCPUs: a round trip a VM, about
200 ms for 150 VMs on a LAN, more with each host. libvirt's domain stats
give them for every VM in one call; a running VM busy with a job is not
waited for (NOWAIT) and its sizes come from its XML as before.
This commit is contained in:
catborise 2026-11-07 15:25:49 +03:00
parent 56a3ca4c99
commit bf736942eb
2 changed files with 37 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

25
vrtManager/tests/test_host_reads.py
View file

@ -158,19 +158,24 @@ class CapacityTestCase(unittest.TestCase):
conn = connection(wvmHostDetails)
gib = 1024 ** 3
kib = gib // 1024
# get_domain_rows: info (state, max memory KiB, memory KiB, vCPUs) and title
conn.get_domain_rows = MagicMock(return_value={
"u-web": ([VIR_DOMAIN_RUNNING, 8 * kib, 4 * kib, 4], ""),
"u-db": ([VIR_DOMAIN_PAUSED, 2 * kib, 2 * kib, 2], ""),
"u-old": ([VIR_DOMAIN_SHUTOFF, 8 * kib, 8 * kib, 8], ""),
})
busy = MagicMock(**{"XMLDesc.return_value": f"<domain><currentMemory>{kib}</currentMemory>"
"<vcpu current='1'>4</vcpu></domain>"})
idle = MagicMock()
# one call for every VM; a VM busy with a job has only its state: its XML gives the rest
conn.wvm.getAllDomainStats = MagicMock(return_value=[
(idle, {"state.state": VIR_DOMAIN_RUNNING, "balloon.current": 4 * kib, "vcpu.current": 4}),
(idle, {"state.state": VIR_DOMAIN_PAUSED, "balloon.current": 2 * kib, "vcpu.current": 2}),
(idle, {"state.state": VIR_DOMAIN_SHUTOFF, "balloon.current": 8 * kib, "vcpu.current": 8}),
(busy, {"state.state": VIR_DOMAIN_RUNNING}),
])
self.assertEqual(conn.get_capacity(), {
"cpus": 4, "memory": 2 * gib,
"vcpus": {"all": 14, "running": 6},
"assigned": {"all": 14 * gib, "running": 6 * gib},
"vms": {"running": 1, "paused": 1, "shutoff": 1, "other": 0},
"vcpus": {"all": 15, "running": 7},
"assigned": {"all": 15 * gib, "running": 7 * gib},
"vms": {"running": 2, "paused": 1, "shutoff": 1, "other": 0},
})
conn.get_domain_rows.assert_called_once_with()
self.assertEqual(conn.wvm.getAllDomainStats.call_count, 1)
idle.XMLDesc.assert_not_called()
class CpuTopologyTestCase(unittest.TestCase):