test: each test is in the tests package of the code it tests

Tests that build vrtManager objects and touch no view, form or model of
an app lived in that app; vrtManager/tests already holds such tests, so
the convention was split. They move to vrtManager/tests: the firmware,
CPU mode and PCIe port definitions of a new VM (test_create), USB and PCI
host devices, the console listener, host CPU reads, interface reads,
deletes and XML, network filters, PCI passthrough rules, node devices,
network changes, addresses and leases, pool XML, secrets, and the live
tests that use vrtManager only (disk resize, ISO, snapshots, XML, live
clone). livetest.py, the live-test helper six apps import, and the
network test driver move with them.

Others go to their app: the quota with a host down to instances, the
401/403 Logs rows (webvirtcloud's middleware) to webvirtcloud, the VM
page's tab script test to instances, novncd's own tests out of the
console views tests, the compute lock and input validation tests out of
the computes views tests, the interface views out of the forms tests.
instances/tests/test_views.py, entirely live, is test_live_views.py.

Test modules imported fixtures from each other; shared ones are now in
vrtManager/tests/fakes.py (migration fakes, node devices, IOMMU groups,
leases, a NAT network, a Ceph secret), interfaces/tests/fakes.py,
console/tests/daemons.py (novncd loaded once), livetest.wait_for and
instances/tests/create_page.BODY. Every live test checks
livetest.enabled(). The suite runs the same 2097 tests.

vrtManager/tests/test_live_clone.py

@@ -15,6 +15,14 @@ from vrtManager.instance import (
     VIR_DOMAIN_BACKUP_BEGIN_PRESERVE_SHUTDOWN_DOMAIN,
     wvmInstance,
 )
+import os
+from xml.etree import ElementTree
+from django.test import SimpleTestCase
+from vrtManager.connection import connection_manager
+from vrtManager.tests import livetest
+
+P = livetest.PREFIX
+
 
 GIB = 1024**3
 UUID = "abababab-0000-1111-2222-333333333333"
@@ -295,3 +303,106 @@ class DefineCloneTestCase(unittest.TestCase):
 
 if __name__ == "__main__":
     unittest.main()
+
+
+class LiveCloneTestCase(SimpleTestCase):
+    @classmethod
+    def setUpClass(cls):
+        if not livetest.enabled():
+            raise unittest.SkipTest("Set TEST_LIBVIRT_HOST to run the live libvirt tests")
+        cls.args = (
+            os.environ["TEST_LIBVIRT_HOST"],
+            os.environ.get("TEST_LIBVIRT_LOGIN", ""),
+            os.environ.get("TEST_LIBVIRT_PASSWORD", ""),
+            int(os.environ.get("TEST_LIBVIRT_TYPE", 4)),
+        )
+        cls.conn = connection_manager.get_connection(*cls.args)
+        livetest.cleanup(cls.conn)
+        livetest.ensure_pool(cls.conn)
+        cls.inventory = livetest.inventory(cls.conn)
+        super().setUpClass()
+
+    @classmethod
+    def tearDownClass(cls):
+        try:
+            livetest.remove_pool(cls.conn)
+        finally:
+            super().tearDownClass()
+        if livetest.inventory(cls.conn) != cls.inventory:
+            raise AssertionError("Live tests changed objects outside the test namespace")
+
+    def tearDown(self):
+        livetest.cleanup(self.conn)
+
+    def pool_volumes(self):
+        pool = self.conn.storagePoolLookupByName(livetest.POOL)
+        pool.refresh(0)
+        return set(pool.listVolumes())
+
+    def source(self, name):
+        disks = [livetest.create_volume(self.conn, P + f"{name}-{d}") for d in ("a", "b")]
+        dom = livetest.define_vm(self.conn, P + name, disks)
+        return dom, wvmInstance(*self.args, None, uuid=dom.UUIDString())
+
+    def clone_data(self, name):
+        return {
+            "name": P + name,
+            "disk-vda": P + name + "-a.qcow2",
+            "disk-vdb": P + name + "-b.qcow2",
+            "disk_owner_uid": 0,
+            "disk_owner_gid": 0,
+        }
+
+    def test_failed_clone_removes_only_its_own_copies(self):
+        _, vm = self.source("clone-src")
+        taken = livetest.create_volume(self.conn, P + "clone-dst-b")  # destination of vdb exists
+        before = self.pool_volumes()
+
+        with self.assertRaises(Exception):
+            vm.clone_instance(self.clone_data("clone-dst"), "abababab-0000-1111-2222-333333333333")
+
+        self.assertEqual(self.pool_volumes(), before, "copies left behind or a volume deleted")
+        self.assertTrue(livetest.volume_exists(self.conn, taken))
+        with self.assertRaises(libvirt.libvirtError):
+            self.conn.lookupByName(P + "clone-dst")
+
+    def test_running_vm_is_not_cloned(self):
+        dom, vm = self.source("clone-run")
+        dom.create()
+        before = self.pool_volumes()
+
+        with self.assertRaises(Exception):
+            vm.clone_instance(self.clone_data("clone-run-copy"), "abababab-0000-1111-2222-333333333333")
+
+        self.assertEqual(self.pool_volumes(), before)
+
+    def test_clone_of_a_uefi_vm_has_its_own_copy_of_the_nvram(self):
+        disk = livetest.create_volume(self.conn, P + "clone-uefi-a")
+        dom = livetest.define_vm(self.conn, P + "clone-uefi", [disk], uefi=True)
+        dom.createWithFlags(libvirt.VIR_DOMAIN_START_PAUSED)  # libvirt makes the NVRAM file at the first start
+        dom.destroy()
+        vm = wvmInstance(*self.args, None, uuid=dom.UUIDString())
+        source = vm.get_nvram()
+
+        uuid = vm.clone_instance(
+            {"name": P + "clone-uefi-copy", "disk-vda": P + "clone-uefi-copy-a.qcow2", "disk_owner_uid": 0, "disk_owner_gid": 0}, "abababab-0000-1111-2222-333333333333"
+        )
+
+        clone = self.conn.lookupByUUIDString(uuid)
+        path = ElementTree.fromstring(clone.XMLDesc(libvirt.VIR_DOMAIN_XML_INACTIVE)).findtext("os/nvram")
+        self.assertEqual(path, os.path.join(os.path.dirname(source), P + "clone-uefi-copy_VARS.fd"))
+        with vm._nvram_pool() as pool:
+            copy = pool.storageVolLookupByName(os.path.basename(path))
+            self.assertEqual(copy.info()[1], pool.storageVolLookupByName(os.path.basename(source)).info()[1])
+        clone.createWithFlags(libvirt.VIR_DOMAIN_START_PAUSED)  # qemu opens the copy
+        self.assertEqual(
+            ElementTree.fromstring(clone.XMLDesc(0)).findtext("os/nvram"), path, "libvirt replaced the copy"
+        )
+        clone.destroy()
+
+    def test_clone_of_a_stopped_vm(self):
+        _, vm = self.source("clone-ok")
+        uuid = vm.clone_instance(self.clone_data("clone-ok-copy"), "abababab-0000-1111-2222-333333333333")
+        clone = self.conn.lookupByUUIDString(uuid)
+        self.assertEqual(clone.name(), P + "clone-ok-copy")
+        self.assertTrue({P + "clone-ok-copy-a.qcow2", P + "clone-ok-copy-b.qcow2"} <= self.pool_volumes())