mirror of
https://github.com/retspen/webvirtcloud
synced 2026-11-09 03:36:48 +00:00
test: each test is in the tests package of the code it tests
Tests that build vrtManager objects and touch no view, form or model of an app lived in that app; vrtManager/tests already holds such tests, so the convention was split. They move to vrtManager/tests: the firmware, CPU mode and PCIe port definitions of a new VM (test_create), USB and PCI host devices, the console listener, host CPU reads, interface reads, deletes and XML, network filters, PCI passthrough rules, node devices, network changes, addresses and leases, pool XML, secrets, and the live tests that use vrtManager only (disk resize, ISO, snapshots, XML, live clone). livetest.py, the live-test helper six apps import, and the network test driver move with them. Others go to their app: the quota with a host down to instances, the 401/403 Logs rows (webvirtcloud's middleware) to webvirtcloud, the VM page's tab script test to instances, novncd's own tests out of the console views tests, the compute lock and input validation tests out of the computes views tests, the interface views out of the forms tests. instances/tests/test_views.py, entirely live, is test_live_views.py. Test modules imported fixtures from each other; shared ones are now in vrtManager/tests/fakes.py (migration fakes, node devices, IOMMU groups, leases, a NAT network, a Ceph secret), interfaces/tests/fakes.py, console/tests/daemons.py (novncd loaded once), livetest.wait_for and instances/tests/create_page.BODY. Every live test checks livetest.enabled(). The suite runs the same 2097 tests.
This commit is contained in:
catborise
parent
4e0952aa50
commit
bdc8a6755c
73 changed files with 2231 additions and 2132 deletions
|
|
@ -1,24 +1,10 @@
|
|||
"""Host interface form: every value is validated before it goes into the interface XML."""
|
||||
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
import libvirt
|
||||
|
||||
from computes.models import Compute
|
||||
from django.contrib.auth import get_user_model
|
||||
from django.test import SimpleTestCase, TestCase
|
||||
from django.urls import reverse
|
||||
from lxml import etree
|
||||
from vrtManager.interface import wvmInterfaces
|
||||
from django.test import SimpleTestCase
|
||||
|
||||
from interfaces.forms import AddInterface
|
||||
|
||||
BASE = {
|
||||
"name": "br1", "itype": "bridge", "start_mode": "onboot", "netdev": "eth1",
|
||||
"ipv4_type": "static", "ipv4_addr": "192.0.2.10/24", "ipv4_gw": "192.0.2.1",
|
||||
"ipv6_type": "static", "stp": "on", "delay": 0,
|
||||
}
|
||||
|
||||
from interfaces.tests.fakes import BASE
|
||||
|
||||
# the host's network devices, as interfaces/views.py passes them
|
||||
NETDEVS = ["eth0", "eth1", "enp129s0f0np0", "eth0.100", "bond-lan"]
|
||||
|
|
@ -71,25 +57,6 @@ class Ipv6FormTestCase(SimpleTestCase):
|
|||
self.assertTrue(form(ipv6_type="dhcp", ipv6_addr="", ipv6_gw="").is_valid())
|
||||
|
||||
|
||||
class Ipv6XmlTestCase(SimpleTestCase):
|
||||
def xml(self, gw):
|
||||
conn = wvmInterfaces.__new__(wvmInterfaces)
|
||||
conn.wvm = MagicMock()
|
||||
conn.define_iface = MagicMock()
|
||||
conn.get_iface = MagicMock()
|
||||
conn.get_iface.return_value.XMLDesc.return_value = "<interface type='ethernet' name='eth1'/>"
|
||||
conn.create_iface("br1", "bridge", "onboot", "eth1", "none", "", "", "static", "2001:db8::10/64", gw, "on", 0)
|
||||
return etree.fromstring(conn.define_iface.call_args[0][0])
|
||||
|
||||
def test_static_address_with_gateway(self):
|
||||
proto = self.xml("2001:db8::1").find("protocol[@family='ipv6']")
|
||||
self.assertEqual(proto.find("ip").attrib, {"address": "2001:db8::10", "prefix": "64"})
|
||||
self.assertEqual(proto.find("route").get("gateway"), "2001:db8::1")
|
||||
|
||||
def test_no_empty_route_without_gateway(self):
|
||||
self.assertIsNone(self.xml("").find("protocol[@family='ipv6']/route"))
|
||||
|
||||
|
||||
class Ipv4FormTestCase(SimpleTestCase):
|
||||
def test_dhcp_and_none_need_no_address(self):
|
||||
for ipv4_type in ("dhcp", "none"):
|
||||
|
|
@ -156,25 +123,6 @@ class InterfaceNameTestCase(SimpleTestCase):
|
|||
self.assertIn("name", f.errors)
|
||||
|
||||
|
||||
class Ipv4XmlTestCase(SimpleTestCase):
|
||||
def xml(self, addr, gw):
|
||||
conn = wvmInterfaces.__new__(wvmInterfaces)
|
||||
conn.wvm = MagicMock()
|
||||
conn.define_iface = MagicMock()
|
||||
conn.get_iface = MagicMock()
|
||||
conn.get_iface.return_value.XMLDesc.return_value = "<interface type='ethernet' name='eth1'/>"
|
||||
conn.create_iface("br1", "bridge", "onboot", "eth1", "static", addr, gw, "none", "", "", "on", 0)
|
||||
return etree.fromstring(conn.define_iface.call_args[0][0])
|
||||
|
||||
def test_static_address_with_gateway(self):
|
||||
proto = self.xml("192.0.2.10/24", "192.0.2.1").find("protocol[@family='ipv4']")
|
||||
self.assertEqual(proto.find("ip").attrib, {"address": "192.0.2.10", "prefix": "24"})
|
||||
self.assertEqual(proto.find("route").get("gateway"), "192.0.2.1")
|
||||
|
||||
def test_no_empty_route_without_gateway(self):
|
||||
self.assertIsNone(self.xml("192.0.2.10/24", "").find("protocol[@family='ipv4']/route"))
|
||||
|
||||
|
||||
class HostDeviceTestCase(SimpleTestCase):
|
||||
def test_a_bridge_member_must_be_a_host_device(self):
|
||||
for netdev in ("eth9", "eth0:1"):
|
||||
|
|
@ -202,89 +150,6 @@ class HostDeviceTestCase(SimpleTestCase):
|
|||
self.assertIn("name", f.errors)
|
||||
|
||||
|
||||
def no_interface(name):
|
||||
err = libvirt.libvirtError("Interface not found: no interface with matching name '%s'" % name)
|
||||
err.err = (libvirt.VIR_ERR_NO_INTERFACE, libvirt.VIR_FROM_INTERFACE, str(err), 2, name, None, None, 0, 0)
|
||||
return err
|
||||
|
||||
|
||||
class BridgeMemberXmlTestCase(SimpleTestCase):
|
||||
"""A bridge member is declared as the host defines it: a bond keeps its
|
||||
mode and devices, a vlan its tag and device."""
|
||||
|
||||
def member(self, host_xml):
|
||||
conn = wvmInterfaces.__new__(wvmInterfaces)
|
||||
conn.wvm = MagicMock()
|
||||
conn.define_iface = MagicMock()
|
||||
|
||||
def get_iface(name):
|
||||
if host_xml is None:
|
||||
raise no_interface(name)
|
||||
iface = MagicMock()
|
||||
iface.XMLDesc.return_value = host_xml
|
||||
return iface
|
||||
|
||||
conn.get_iface = MagicMock(side_effect=get_iface)
|
||||
conn.create_iface("br1", "bridge", "onboot", "bond0", "none", "", "", "none", "", "", "on", 0)
|
||||
self.assertTrue(conn.define_iface.return_value.create.called)
|
||||
members = etree.fromstring(conn.define_iface.call_args[0][0]).findall("bridge/interface")
|
||||
self.assertEqual(len(members), 1)
|
||||
return members[0]
|
||||
|
||||
def test_a_bond_keeps_its_mode_and_devices(self):
|
||||
member = self.member(
|
||||
"<interface type='bond' name='bond0'><start mode='onboot'/><mtu size='9000'/>"
|
||||
"<protocol family='ipv4'><dhcp/></protocol>"
|
||||
"<bond mode='active-backup'><miimon freq='100'/>"
|
||||
"<interface type='ethernet' name='eth0'><mac address='52:54:00:00:00:01'/></interface>"
|
||||
"<interface type='ethernet' name='eth1'/></bond></interface>"
|
||||
)
|
||||
self.assertEqual((member.get("type"), member.get("name")), ("bond", "bond0"))
|
||||
self.assertEqual(member.find("bond").get("mode"), "active-backup")
|
||||
self.assertEqual([i.get("name") for i in member.findall("bond/interface")], ["eth0", "eth1"])
|
||||
self.assertEqual(member.find("bond/miimon").get("freq"), "100")
|
||||
# what only a top-level interface has: the bridge holds the addresses
|
||||
for tag in ("start", "mtu", "protocol"):
|
||||
self.assertIsNone(member.find(tag), tag)
|
||||
|
||||
def test_a_vlan_keeps_its_tag_and_device(self):
|
||||
member = self.member(
|
||||
"<interface type='vlan' name='bond0'><start mode='onboot'/>"
|
||||
"<vlan tag='42'><interface name='eth0'/></vlan></interface>"
|
||||
)
|
||||
self.assertEqual(member.get("type"), "vlan")
|
||||
self.assertEqual(member.find("vlan").get("tag"), "42")
|
||||
self.assertEqual(member.find("vlan/interface").get("name"), "eth0")
|
||||
self.assertIsNone(member.find("start"))
|
||||
|
||||
def test_a_device_the_host_does_not_define_is_ethernet(self):
|
||||
member = self.member(None)
|
||||
self.assertEqual(member.attrib, {"type": "ethernet", "name": "bond0"})
|
||||
|
||||
def test_other_lookup_errors_are_not_hidden(self):
|
||||
conn = wvmInterfaces.__new__(wvmInterfaces)
|
||||
conn.wvm = MagicMock()
|
||||
conn.define_iface = MagicMock()
|
||||
err = libvirt.libvirtError("cannot recv data")
|
||||
err.err = (libvirt.VIR_ERR_SYSTEM_ERROR, libvirt.VIR_FROM_RPC, str(err), 2, None, None, None, 0, 0)
|
||||
conn.get_iface = MagicMock(side_effect=err)
|
||||
with self.assertRaises(libvirt.libvirtError):
|
||||
conn.create_iface("br1", "bridge", "onboot", "bond0", "none", "", "", "none", "", "", "on", 0)
|
||||
self.assertFalse(conn.define_iface.called)
|
||||
|
||||
def test_an_interface_that_does_not_start_is_rolled_back(self):
|
||||
# the definition, and the member's own configuration it changed, as they were
|
||||
conn = wvmInterfaces.__new__(wvmInterfaces)
|
||||
conn.wvm = MagicMock()
|
||||
conn.define_iface = MagicMock()
|
||||
iface = conn.define_iface.return_value
|
||||
iface.create.side_effect = libvirt.libvirtError("failed to bring up br1")
|
||||
with self.assertRaises(libvirt.libvirtError):
|
||||
conn.create_iface("br1", "ethernet", "onboot", "", "none", "", "", "none", "", "", "on", 0)
|
||||
conn.wvm.changeRollback.assert_called_once_with(0)
|
||||
conn.wvm.changeCommit.assert_not_called()
|
||||
|
||||
|
||||
class BridgeSettingsTestCase(SimpleTestCase):
|
||||
def test_a_bridge_needs_stp_and_a_delay(self):
|
||||
for field in ("stp", "delay"):
|
||||
|
|
@ -313,152 +178,6 @@ class AddressNotationTestCase(SimpleTestCase):
|
|||
self.assertIn(field, f.errors)
|
||||
|
||||
|
||||
class CreateViewTestCase(TestCase):
|
||||
"""The page validates the device against the host's devices before it
|
||||
defines an interface."""
|
||||
|
||||
def test_only_a_host_device_becomes_a_bridge_member(self):
|
||||
admin = get_user_model().objects.create_superuser("iface_admin", "a@example.com", "x")
|
||||
compute = Compute.objects.create(name="iface-c", hostname="127.0.0.1:1", login="root", password="", type=1)
|
||||
self.client.force_login(admin)
|
||||
for netdev, created in (("eth9", False), ("eth0", True)):
|
||||
with self.subTest(netdev=netdev), patch("interfaces.views.wvmInterfaces") as conn_cls:
|
||||
conn = conn_cls.return_value
|
||||
conn.get_ifaces_info.return_value = []
|
||||
conn.can_change_interfaces.return_value = True
|
||||
conn.get_net_devices.return_value = ["eth0", "eth1"]
|
||||
conn.get_member_candidates.return_value = ["eth0", "eth1"]
|
||||
self.client.post(
|
||||
reverse("interfaces", args=[compute.id]),
|
||||
{**BASE, "netdev": netdev, "ipv6_type": "none", "create": ""},
|
||||
)
|
||||
self.assertEqual(conn.create_iface.called, created)
|
||||
|
||||
def test_a_device_taken_meanwhile_is_chosen_again(self):
|
||||
# not swapped for the first device the dialog still offers
|
||||
admin = get_user_model().objects.create_superuser("iface_admin3", "c@example.com", "x")
|
||||
compute = Compute.objects.create(name="iface-c3", hostname="127.0.0.1:1", login="root", password="", type=1)
|
||||
self.client.force_login(admin)
|
||||
for select, values in (("iface_netdev", {"netdev": "eth1"}), ("iface_device", {"itype": "ethernet", "name": "eth1", "netdev": "eth0"})):
|
||||
with self.subTest(**values), patch("interfaces.views.wvmInterfaces") as conn_cls:
|
||||
conn = conn_cls.return_value
|
||||
conn.get_ifaces_info.return_value = []
|
||||
conn.can_change_interfaces.return_value = True
|
||||
conn.get_net_devices.return_value = ["eth0", "eth1"]
|
||||
conn.get_member_candidates.return_value = ["eth0"]
|
||||
page = self.client.post(reverse("interfaces", args=[compute.id]),
|
||||
{**BASE, **values, "ipv6_type": "none", "create": ""}).content.decode()
|
||||
self.assertFalse(conn.create_iface.called)
|
||||
chosen = etree.HTML(page).xpath(f"//select[@id='{select}']/option[@selected]/@value")
|
||||
self.assertEqual(chosen, [""])
|
||||
|
||||
def test_unreadable_host_devices_are_reported_not_blamed_on_the_input(self):
|
||||
admin = get_user_model().objects.create_superuser("iface_admin2", "b@example.com", "x")
|
||||
compute = Compute.objects.create(name="iface-c2", hostname="127.0.0.1:1", login="root", password="", type=1)
|
||||
self.client.force_login(admin)
|
||||
with patch("interfaces.views.wvmInterfaces") as conn_cls:
|
||||
conn = conn_cls.return_value
|
||||
conn.get_ifaces_info.return_value = []
|
||||
conn.can_change_interfaces.return_value = True
|
||||
conn.get_net_devices.side_effect = RuntimeError("nodedev driver not running")
|
||||
response = self.client.post(
|
||||
reverse("interfaces", args=[compute.id]),
|
||||
{**BASE, "netdev": "eth0", "ipv6_type": "none", "create": ""},
|
||||
)
|
||||
self.assertFalse(conn.create_iface.called)
|
||||
messages = [str(m) for m in response.context["messages"]]
|
||||
self.assertTrue(any("nodedev driver not running" in m for m in messages), messages)
|
||||
self.assertFalse(any("not on this host" in m for m in messages), messages)
|
||||
|
||||
|
||||
class InterfaceListTestCase(TestCase):
|
||||
def test_the_interfaces_are_grouped_by_type(self):
|
||||
self.client.force_login(get_user_model().objects.create_superuser("iface_list", "l@example.com", "x"))
|
||||
compute = Compute.objects.create(name="iface-list", hostname="127.0.0.1:1", login="root", password="", type=1)
|
||||
ifaces = [{"name": name, "type": kind, "mac": None, "link": "up", "members": []}
|
||||
for name, kind in (("br0", "bridge"), ("eth0", "ethernet"), ("eth1", "ethernet"))]
|
||||
with patch("interfaces.views.wvmInterfaces") as conn_cls:
|
||||
conn_cls.return_value.get_ifaces_info.return_value = ifaces
|
||||
conn_cls.return_value.can_change_interfaces.return_value = False
|
||||
page = etree.HTML(self.client.get(reverse("interfaces", args=[compute.id])).content.decode())
|
||||
# no heading for a type the host has none of
|
||||
self.assertEqual([" ".join(h.itertext()).split() for h in page.xpath("//h2")], [["Bridges", "1"], ["Ethernet", "2"]])
|
||||
|
||||
|
||||
class UnchangeableHostTestCase(TestCase):
|
||||
"""A host whose libvirt cannot change interfaces (udev backend) gets no
|
||||
create form and no start/stop/delete, only a note; posts change nothing."""
|
||||
|
||||
NOTE = "only reads network interfaces"
|
||||
|
||||
def setUp(self):
|
||||
self.client.force_login(get_user_model().objects.create_superuser("iface_ro", "ro@example.com", "x"))
|
||||
self.compute = Compute.objects.create(name="iface-ro", hostname="127.0.0.1:1", login="root", password="", type=1)
|
||||
|
||||
def interfaces_page(self, changeable, post=None):
|
||||
with patch("interfaces.views.wvmInterfaces") as conn_cls:
|
||||
conn = conn_cls.return_value
|
||||
conn.get_ifaces_info.return_value = []
|
||||
conn.can_change_interfaces.return_value = changeable
|
||||
conn.get_net_devices.return_value = ["eth0", "eth1"]
|
||||
url = reverse("interfaces", args=[self.compute.id])
|
||||
response = self.client.post(url, post) if post else self.client.get(url)
|
||||
return conn, response.content.decode()
|
||||
|
||||
def test_the_interfaces_page_offers_create_only_where_it_works(self):
|
||||
for changeable in (True, False):
|
||||
with self.subTest(changeable=changeable):
|
||||
conn, page = self.interfaces_page(changeable)
|
||||
self.assertEqual("#AddInterface" in page, changeable)
|
||||
self.assertEqual(self.NOTE in page, not changeable)
|
||||
# the devices are only the form's choices
|
||||
self.assertEqual(conn.get_net_devices.called, changeable)
|
||||
|
||||
def test_a_create_post_creates_nothing(self):
|
||||
conn, page = self.interfaces_page(False, {**BASE, "netdev": "eth1", "ipv6_type": "none", "create": ""})
|
||||
conn.create_iface.assert_not_called()
|
||||
self.assertIn(self.NOTE, page)
|
||||
|
||||
def interface_page(self, changeable, state, post=None):
|
||||
with patch("interfaces.views.wvmInterface") as conn_cls:
|
||||
conn = conn_cls.return_value
|
||||
conn.can_change_interfaces.return_value = changeable
|
||||
conn.is_active.return_value = state
|
||||
url = reverse("interface", args=[self.compute.id, "br0"])
|
||||
response = self.client.post(url, post) if post else self.client.get(url)
|
||||
return conn, response
|
||||
|
||||
def test_the_interface_page_shows_the_state_without_actions(self):
|
||||
# libvirt's own state is told where it manages the interface only; the link always
|
||||
for state in (1, 0):
|
||||
with self.subTest(state=state):
|
||||
conn, response = self.interface_page(False, state)
|
||||
page = response.content.decode()
|
||||
self.assertNotIn('name="start"', page)
|
||||
self.assertNotIn('name="stop"', page)
|
||||
self.assertNotIn(">Active<", page)
|
||||
self.assertIn(self.NOTE, page)
|
||||
_conn, response = self.interface_page(True, 0)
|
||||
page = response.content.decode()
|
||||
self.assertIn('name="start"', page)
|
||||
self.assertIn(">Inactive<", page)
|
||||
|
||||
def test_a_host_that_could_not_be_read_offers_nothing(self):
|
||||
# not knowing whether the host can change interfaces is not a yes
|
||||
with patch("interfaces.views.wvmInterface", side_effect=libvirt.libvirtError("unreachable")):
|
||||
page = self.client.get(reverse("interface", args=[self.compute.id, "br0"])).content.decode()
|
||||
self.assertNotIn(self.NOTE, page)
|
||||
self.assertNotIn("Interface start/stop/delete form", page)
|
||||
|
||||
def test_start_stop_and_delete_posts_change_nothing(self):
|
||||
for action in ("start", "stop", "delete"):
|
||||
with self.subTest(action=action):
|
||||
conn, response = self.interface_page(False, 1, {action: ""})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
for method in (conn.start_iface, conn.stop_iface, conn.delete_iface):
|
||||
method.assert_not_called()
|
||||
|
||||
|
||||
class EthernetDeviceTestCase(SimpleTestCase):
|
||||
def test_an_ethernet_interface_needs_no_bridge_member(self):
|
||||
self.assertTrue(form(itype="ethernet", name="eth0", netdev="", ipv6_type="none").is_valid())
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue