From 9e92d208db0865ee3a573e486119bf80f3afa544 Mon Sep 17 00:00:00 2001 From: catborise Date: Sat, 3 Oct 2026 13:27:47 +0300 Subject: [PATCH] fix(instances): flavor redirects and create-from-XML crashed - Flavor create/update/delete fell back to the nonexistent instances:flavors URL; reverse() ran on every request, so each of them raised NoReverseMatch. Fall back to instances:index. - Creating a VM from XML called instances.utils.refresh_instance_database, which does not exist; use utils.refr. Both found by running the live libvirt suite. --- instances/views.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/instances/views.py b/instances/views.py index 8e7962a3..28d8d585 100755 --- a/instances/views.py +++ b/instances/views.py @@ -1936,7 +1936,7 @@ def create_instance_select_type(request, compute_id): else: with libvirt_compute_lock(compute): conn._defineXML(xml) - utils.refresh_instance_database(compute) + utils.refr(compute) instance = compute.instance_set.get(name=name) return redirect(reverse("instances:instance", args=[instance.id])) @@ -2219,7 +2219,7 @@ def flavor_create(request): if form.is_valid(): form.save() messages.success(request, _("Flavor Created")) - return get_safe_redirect(request, default=reverse("instances:flavors")) + return get_safe_redirect(request, default=reverse("instances:index")) return render( request, @@ -2235,7 +2235,7 @@ def flavor_update(request, pk): if form.is_valid(): form.save() messages.success(request, _("Flavor Updated")) - return get_safe_redirect(request, default=reverse("instances:flavors")) + return get_safe_redirect(request, default=reverse("instances:index")) return render( request, @@ -2250,7 +2250,7 @@ def flavor_delete(request, pk): if request.method == "POST": flavor.delete() messages.success(request, _("Flavor Deleted")) - return get_safe_redirect(request, default=reverse("instances:flavors")) + return get_safe_redirect(request, default=reverse("instances:index")) return render( request,