j3d1/webvirtcloud
1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud synced 2026-11-09 11:46:49 +00:00
Code Issues Projects Releases Wiki Activity

fix(datasource): cloud-init endpoints work without login, keys need a unique name

Browse source 
The OpenStack-style cloud-init endpoints (index, meta_data.json,
user_data) are fetched by booting VMs, which do not log in. Since the
login-required middleware they redirected to the login page, so the
datasource has not worked. They are login_not_required now; they expose
a hostname and the public SSH keys of a VM's owners.

A VM is found by the reverse DNS name of the client address, and VM
names are not unique (only compute and UUID are). user_data merged the
owners of every VM with that name, so a user who named their VM like
another user's VM got their key into that VM at its next cloud-init
run. Keys are now given only when exactly one VM has the name.

The client address is the last X-Forwarded-For entry, which nginx in
the default setup appends; gunicorn listens on 127.0.0.1 only. The bare
except around the reverse lookup is narrowed to OSError.
This commit is contained in:
catborise 2026-10-04 20:46:15 +03:00
parent 99dabbdcec
commit 99eadaab31
3 changed files with 64 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

22
datasource/views.py
View file

@ -2,6 +2,7 @@ import socket
from accounts.models import UserInstance, UserSSHKey
from computes.models import Compute
from django.contrib.auth.decorators import login_not_required
from django.core.exceptions import PermissionDenied
from django.http import Http404, HttpResponse, JsonResponse
from django.shortcuts import get_object_or_404, render
@ -14,6 +15,11 @@ OS_VERSIONS = ["latest", ""]
OS_UUID = "iid-dswebvirtcloud"
# The cloud-init endpoints are fetched by booting VMs, which do not log in.
# They expose only a hostname and the public SSH keys of a VM's owners.
@login_not_required
def os_index(request):
"""
:param request:
@ -23,6 +29,7 @@ def os_index(request):
return HttpResponse(response)
@login_not_required
def os_metadata_json(request, version):
"""
:param request:
@ -40,6 +47,7 @@ def os_metadata_json(request, version):
raise Http404(err)
@login_not_required
def os_userdata(request, version):
"""
:param request:
@ -52,12 +60,12 @@ def os_userdata(request, version):
vname = hostname.split(".")[0]
instance_keys = []
userinstances = UserInstance.objects.filter(instance__name=vname)
for ui in userinstances:
keys = UserSSHKey.objects.filter(user=ui.user)
for k in keys:
instance_keys.append(k.keypublic)
# VM names are not unique: with two VMs of this name, a user could put
# their key into the other VM by naming theirs the same. No keys then.
instances = list(Instance.objects.filter(name=vname)[:2])
if len(instances) == 1:
for ui in UserInstance.objects.filter(instance=instances[0]):
instance_keys += UserSSHKey.objects.filter(user=ui.user).values_list("keypublic", flat=True)
return render(request, "user_data", locals())
else:
@ -85,7 +93,7 @@ def get_hostname_by_ip(ip):
"""
try:
addrs = socket.gethostbyaddr(ip)
except:
except OSError: # no reverse DNS entry or an invalid address
addrs = [ip]
return addrs[0]