j3d1/webvirtcloud
1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud synced 2026-11-11 12:46:49 +00:00
Code Issues Projects Releases Wiki Activity

feat(logs): admin changes and logins are recorded on the Logs page

Browse source 
The Logs page shows who added, changed or deleted a compute, from web
or API, and every login, failed login, lockout and logout, with the
client address and a Result column (Done, Failed, Unknown for older
rows). A failed change is recorded with its reason and the error still
reaches the user; a refused one is recorded too.

- logs.audit.write saves each row in its own savepoint and never
  raises, so a log write cannot break or undo the action it records.
  The audit() context manager writes one row when the change ends.
- Logs gains success and ip; user, host and instance are wider and
  date is indexed. The page orders by date then id.
- A compute edit names the changed fields; an edit that changes
  nothing writes no row, and an empty password field is no change.
- A compute's VMs leaving the panel get a system row each: owners
  kept on the Removed VMs page, moved to another compute, restored,
  left without owners, or the removed record expired.
- Job rows carry the result. A job's log entry that cannot be
  computed is logged and skipped instead of rolling back the finish
  (test_service.py changes this on purpose).
- Logins are recorded by signal receivers; CustomLoginView is removed
  and the plain LoginView is used. A wrong OTP code is a failed login,
  counted by django-axes toward the lockout.

Panel records and host-side objects follow in the next layers.
This commit is contained in:
catborise 2026-10-23 09:46:36 +03:00
parent ac6bc48f88
commit 8c0fbff8f7
24 changed files with 639 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

26
operations/tests/test_service.py
View file

@ -90,12 +90,26 @@ class CancelFinishResolveTestCase(TransactionTestCase):
self.assertFalse(Claim.objects.exists())
self.assertEqual(list(Logs.objects.values_list("message", flat=True)), ["No-op cancelled"])
def test_the_log_entry_is_written_inside_the_finishing_transaction(self):
def test_a_failing_log_entry_does_not_undo_the_finish(self):
op = jobs.submit("test.noop", self.user, {}, KEY)
with patch.object(fakes.NoopKind, "log_entry", side_effect=RuntimeError("x")), self.assertRaises(RuntimeError):
jobs.finish(op, Outcome(Operation.SUCCEEDED))
self.assertEqual(Operation.objects.get(pk=op.pk).state, Operation.QUEUED) # rolled back
self.assertTrue(Claim.objects.exists())
with patch.object(fakes.NoopKind, "log_entry", side_effect=RuntimeError("x")), \
self.assertLogs("logs.audit", "ERROR"):
self.assertTrue(jobs.finish(op, Outcome(Operation.SUCCEEDED)))
self.assertEqual(Operation.objects.get(pk=op.pk).state, Operation.SUCCEEDED)
self.assertFalse(Claim.objects.exists())
self.assertFalse(Logs.objects.exists())
def test_job_rows_carry_the_result(self):
for key, state, success in (("key-00000002", Operation.SUCCEEDED, True), ("key-00000003", Operation.FAILED, False)):
jobs.finish(jobs.submit("test.noop", self.user, {}, key), Outcome(state))
self.assertIs(Logs.objects.latest("pk").success, success)
jobs.cancel(jobs.submit("test.noop", self.user, {}, "key-00000004").pk, self.user)
self.assertIsNone(Logs.objects.latest("pk").success)
op = jobs.submit("test.noop", self.user, {}, "key-00000005")
jobs.finish(op, Outcome(Operation.UNCERTAIN))
self.assertIsNone(Logs.objects.latest("pk").success)
jobs.resolve(op.pk, self.admin, Operation.FAILED, "checked")
self.assertIs(Logs.objects.latest("pk").success, False)
def test_cancel_decides_from_the_current_state(self):
op = jobs.submit("test.scripted", self.user, {}, KEY)
@ -176,7 +190,7 @@ class CancelFinishResolveTestCase(TransactionTestCase):
jobs.finish(op, Outcome(Operation.FAILED, error="qemu+tcp://admin:s3cret@192.0.2.5/system failed"))
op.refresh_from_db()
self.assertNotIn("s3cret", op.error)
self.assertLessEqual(len(Logs.objects.get().user), 50)
self.assertLessEqual(len(Logs.objects.get().user), 150)
def test_an_uncertain_job_keeps_its_claims_until_resolved(self):
op = jobs.submit("test.noop", self.user, {}, KEY)