1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud synced 2026-11-11 12:46:49 +00:00

fix(api): host API checks what the web forms check

- An API volume takes the name and size the web form takes. Its name went
  into the volume XML unchecked, so a name could add elements such as a
  backing store pointing at another VM's disk; the name is also escaped
  there now. A size of 0 and metadata preallocation on a non-qcow2 volume
  are refused or dropped, as on the web form.
- An API compute update with an empty or null password keeps the stored
  one, as the web form does; it emptied it and cut the host off.
- The architectures endpoint answers 404 for an unknown compute instead of
  500; an unrouted copy of it is removed.
This commit is contained in:
catborise 2026-10-26 17:07:05 +03:00
parent c69c65728b
commit 726f330dd0
7 changed files with 34 additions and 21 deletions

View file

@ -20,6 +20,10 @@ class ComputeSerializer(serializers.ModelSerializer):
)
type = serializers.ChoiceField(choices=conn_types)
def validate_password(self, value):
# as on the web form, an empty password on an edit keeps the stored one
return value or (self.instance.password if self.instance else value)
class Meta:
model = Compute
fields = ["id", "name", "hostname", "login", "password", "type", "details", "migration_address"]