mirror of
https://github.com/retspen/webvirtcloud
synced 2026-11-11 12:46:49 +00:00
fix: serve JSON endpoints as application/json and build DOM safely
Several views returned json.dumps() output through HttpResponse, i.e. as text/html, and guess_mac_address reflects the URL's vname into it (reflected XSS). Templates filled the log table and volume dropdowns by concatenating server data into HTML strings, and log messages contain user-entered snapshot/disk/clone names (stored XSS that runs when a superuser opens the Logs tab). - Use JsonResponse in guess_mac_address, random_mac_address, guess_clone_name, sshkeys, storages.get_volumes, datasource.os_metadata_json and logs.vm_logs; sshkeys?plain=true is served as text/plain. - stats_tab.html builds log rows with .text(); instance.html and create_instance_w2.html build <option> elements with .val().text().
This commit is contained in:
parent
b1ab1d47fa
commit
4546653b5a
8 changed files with 140 additions and 29 deletions
|
|
@ -150,13 +150,16 @@
|
|||
$("#vols").removeAttr("disabled");
|
||||
|
||||
$.each(data['vols'], function(i, item) {
|
||||
$("#vols").append('<option value=' + item +'>' + item + '</option>');
|
||||
$("#vols").append($("<option>").val(item).text(item));
|
||||
})
|
||||
});
|
||||
|
||||
var sto_drop = document.getElementById('select_storage');
|
||||
sto_drop.value = pool;
|
||||
sto_drop.innerHTML = pool + "<span class=\"caret\"></span>";
|
||||
sto_drop.textContent = pool;
|
||||
var caret = document.createElement("span");
|
||||
caret.className = "caret";
|
||||
sto_drop.appendChild(caret);
|
||||
|
||||
var sto_input = document.getElementById('selected_storage');
|
||||
sto_input.setAttribute('value', pool);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue