j3d1/webvirtcloud
1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud synced 2026-11-10 12:16:49 +00:00
Code Issues Projects Releases Wiki Activity

fix(instances): a migrated VM's source definition is always removed

Browse source 
Migration left the VM defined on the source host unless "Delete
original" was ticked (VIR_MIGRATE_UNDEFINE_SOURCE). With the shared
storage migration needs, that definition points at the disks the
destination VM is running on: the VM showed on both hosts and could be
started (or autostarted) a second time against the same disks; only a
configured lock manager stops that.

moveto now always passes VIR_MIGRATE_UNDEFINE_SOURCE with
VIR_MIGRATE_PERSIST_DEST. The option is gone from the form, the view,
the API (MigrateSerializer.xml_del) and the clone auto-migration. It
removes the definition, not the disk files.
This commit is contained in:
catborise 2026-10-06 11:52:51 +03:00
parent 1ce7dbf18e
commit 25b3671c33
8 changed files with 56 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

2
instances/api/serializers.py
View file

@ -91,7 +91,6 @@ class CreateInstanceSerializer(serializers.ModelSerializer):
class MigrateSerializer(serializers.ModelSerializer):
instance = Instance.objects.all().prefetch_related("userinstance_set")
live = serializers.BooleanField(initial=True)
xml_del = serializers.BooleanField(initial=True)
class Meta:
model = MigrateInstance
@ -99,7 +98,6 @@ class MigrateSerializer(serializers.ModelSerializer):
"instance",
"target_compute",
"live",
"xml_del",
"offline",
"autoconverge",
"compress",

2
instances/api/viewsets.py
View file

@ -193,7 +193,6 @@ class MigrateViewSet(viewsets.ViewSet):
target_host = serializer.validated_data["target_compute"]
live = serializer.validated_data["live"]
unsafe = serializer.validated_data["unsafe"]
xml_del = serializer.validated_data["xml_del"]
offline = serializer.validated_data["offline"]
autoconverge = serializer.validated_data["autoconverge"]
postcopy = serializer.validated_data["postcopy"]
@ -205,7 +204,6 @@ class MigrateViewSet(viewsets.ViewSet):
request.user,
live,
unsafe,
xml_del,
offline,
autoconverge,
compress,