Commit graph

3071 commits

Author SHA1 Message Date
Rafał Leśniak
b3607cd5f9 Merge pull request #4 from lemoer/patch-fix-pong-handler
Patchset to improve the pong handler

It seem that we have some troll in the network or something is broken.
2016-05-18 22:53:45 +02:00
thorkill
ad540d0c09 Lower message level on SLPD expire 2016-05-18 22:41:09 +02:00
lemoer
532b9ca451 pong handler: fix incorrect calculation for rtt
Before this fix seconds were treated as milliseconds.

Example:

A ping of 1.001s resulted in current_rtt = 2 (ms)
where a ping of 0.999s resulted in current_rtt = 999 (ms).
2016-05-18 22:21:37 +02:00
lemoer
762dc69a59 pong handler: rtt and timestamps are always positive 2016-05-18 22:21:29 +02:00
lemoer
25317983c7 pong handler: add warning if we receive pong without ping 2016-05-18 21:22:03 +02:00
lemoer
8f21a5da81 pong handler: add sanity check for rtt 2016-05-18 21:20:47 +02:00
thorkill
9deb664a94 Added .dir-locals.el for the emacs devs 2016-05-18 21:02:24 +02:00
thorkill
a6543c144d Cleanup dynamically allocated buffer before use 2016-05-18 01:08:05 +02:00
thorkill
68beb519b4 Turn -Wformat to -Werror=format, got some wrong habits 2016-05-17 23:34:07 +02:00
thorkill
90c1341626 Initialize buffer for decryption - just in case 2016-05-17 23:06:53 +02:00
thorkill
3e9638b0cb msg buffer may contain random data - just clean it up 2016-05-17 22:55:16 +02:00
thorkill
ff8f57c130 Implemented SLPD information expiration and added support for port 2016-05-17 14:46:19 +02:00
Rafał Leśniak
e567374a5d Merge pull request #3 from lemoer/patch-fix-gcc
Fix type conversion warnings for gcc in SLPD
2016-05-17 13:51:40 +02:00
lemoer
7b220b1464 Fix type conversation warnings for gcc in slpd. 2016-05-17 11:30:03 +02:00
thorkill
d28dece937 Proper length validation in handle_incoming_slpd_packet
- refactor and cleanup of unused variables
2016-05-17 11:12:55 +02:00
thorkill
4cb85c00a8 First attempt to sign and verify the SLPD data 2016-05-16 23:21:02 +02:00
thorkill
43ed440176 SLPD rewrite for IPv6 - IPv4 has been dropped
After first tests it came out, that RoadWarriors with multiple
active Interfaces hat problems with receiving on/ and sending SLPD
packets to specific interfaces.

Here the solution:
- Define SLPDInterface in your tinc.conf (multiple definitions are allowed)
  On those interfaces tincd will send and receive SLPD packetes
- You have to have IPv6 support on - link-local addresses configured
- tincd must listen on IPv6 on your SLPDInterfaces
- Define SLPDGroup to something like ff02::42:1
- Define SLPDPort for your group
- Define SLPDInterval to some sane number of seconds (0 is default,
meaning SLPD is disabled, 30 seconds should be enough for average
users)

SLPDGroup and SLPDPort should be unique for your network.

Fingerprinting, message signing is yet to be implemented.
Discovered address should also expire periodically.
2016-05-16 20:11:08 +02:00
thorkill
057ccb8da6 recvfrom return size_t not len 2016-05-15 19:12:41 +02:00
thorkill
e36af42ce4 Change type of the packet. 2016-05-15 18:48:24 +02:00
thorkill
99e0f5777c Small typo fix and set slpd sockt O_NONBLOCK 2016-05-15 17:24:07 +02:00
thorkill
756a6607e1 Silence log output 2016-05-15 00:39:18 +02:00
thorkill
cdd148204f Introduction to Simple Local Peer Discovery Protocol (SLPD)
Full functionality of tinc mesh relays on having at least one node,
accessible, with known address to which all other nodes must connect
in order to exchange information about other peers.

Sometimes, however, in smaller networks or if two or more peers are
located in the same LAN segment without access to any of the nodes with
known address, there is no way of establishing a functional mesh
without manually changing the configuration.

SLPD addresses this problem utilizing multicast groups and autoconnect.
- Node sends periodically simple message to multicast group
  (default 224.0.42.23 port 1655) in this format:
   "sLPD 0 1 nodename port publickey"

   "0 1" is the "major minior" version of the protocol

- Node listens to the multicast group for messages on all interfaces:
  - if the nodename is known and the publickey matches the
    node's public key the source address of the packet
    will be stored as learned ip address

- at this point setup_outgoing_connection() will be able to
  choose the learned ip for connect

Configarion example:
* Roadwarriors: SLPDInterval = 30
* Router on your home network or in your hackerspace:
 - It should broadcast only in the direction of the LAN thus you should
   set SLPDInterface = eth0 and SLPDInterval = 10
* Defaults:
 SLPDGroup = "224.0.42.23"
 SLPDPort = 1655
 SLPDInterval = 0 (means SLPD is disabled)

The check of the publickey is not implemented yet. IPv6 support
must be implemented. This is the first commit - highly experimental.
2016-05-15 00:24:35 +02:00
thorkill
4401c645ab Silence log messages on autoconnect 2016-05-14 23:21:36 +02:00
thorkill
39b23f7a11 Make edge update work when compiled with --disable-legacy 2016-05-14 23:18:44 +02:00
thorkill
231bd39986 Merge branch 'thkr-1.1-ponyhof' into thkr-1.1-1462915768-ein7jahS 2016-05-12 13:40:14 +02:00
thorkill
e4619ecce1 Merge remote-tracking branch 'guus/1.1' into thkr-1.1-ponyhof 2016-05-12 13:39:14 +02:00
thorkill
ddc74678b2 Fixed log message - it is destination not source address 2016-05-12 13:16:01 +02:00
thorkill
0cf943753a Send PKT_PROBE only when handshake has been done already. 2016-05-12 11:20:41 +02:00
thorkill
3ec36e6432 We still need excessive sptps logging 2016-05-11 23:39:09 +02:00
thorkill
3558ab5499 Removed additional debug output 2016-05-11 23:39:03 +02:00
thorkill
b27e9bfd74 We still need excessive sptps logging 2016-05-11 22:54:00 +02:00
thorkill
ca601087fc Removed additional debug output 2016-05-11 21:58:14 +02:00
thorkill
79621fd167 Merge branch 'thkr-1.1-ponyhof' into thkr-1.1-1462915768-ein7jahS 2016-05-11 19:41:40 +02:00
thorkill
ae199d9f2b Removed type check and debug output.
We will send PKT_PROBE in send_sptps_packet only if handshake has been completed.
2016-05-11 19:30:58 +02:00
thorkill
62064cc5ef Send PKT_PROBE only when handshake has been done already. 2016-05-11 19:30:07 +02:00
thorkill
c1af41e7f0 Removed type check and debug output.
We will send PKT_PROBE in send_sptps_packet only if handshake has been completed.
2016-05-11 19:29:04 +02:00
thorkill
037411aa29 Send PKT_PROBE only when handshake has been done already. 2016-05-11 19:27:05 +02:00
thorkill
a84019cf10 Split error handling for accurate log messages in sptps_verify_datagram
"Received short packet" was misleading.
2016-05-11 18:51:57 +02:00
thorkill
d0e9430a8c Split error handling for accurate log messages in sptps_verify_datagram
"Received short packet" was misleading.
2016-05-11 18:50:12 +02:00
thorkill
b585596082 Merge branch 'thkr-1.1-ponyhof' into thkr-1.1-1462915768-ein7jahS 2016-05-11 18:39:39 +02:00
thorkill
fe18e0ed29 Reverted changes to try_tx_sptps
- should fix the problem with unknown source
at the beginning of communication between nodes
2016-05-11 18:39:15 +02:00
thorkill
40acedd793 Reverted changes to try_tx_sptps
- should fix the problem with unknown source
at the beginning of communication between nodes
2016-05-11 18:37:01 +02:00
thorkill
41e801cbbd Revert "Temporal fix for 'unknown source' and broken direct UDP links."
This reverts commit 157bc90e64.
2016-05-10 23:51:22 +02:00
thorkill
0e6265f546 Removed backtrace callback function 2016-05-10 13:43:25 +02:00
thorkill
9d8af84933 Merge branch 'thkr-1.1-20160510-fix-pkt_probe' into thkr-1.1-ponyhof 2016-05-10 12:01:13 +02:00
thorkill
bd95c231ce Merge branch 'thkr-1.1-20160510-fix-receive_tcppacket_sptps' into thkr-1.1-ponyhof 2016-05-10 12:01:06 +02:00
thorkill
dc8ee9e6d1 Prevent receive_tcppacket_sptps from forwarding data when we are in handshake phase with those nodes
Forwarding data to node which does not have vaildkey yet would destroy
the running handshake.
2016-05-10 11:43:14 +02:00
thorkill
f7e2020b56 Allow PKT_PROBE in sptps_send_record
sptps_send_record prevented PKT_PROBE to be send in send_sptps_packet.
This occurred mostly when data was on "the wire" for some subnet.
route() would then trigger try_tx/try_udp which would be dropped by
sptps_send_record producing annoying amount of "Handshake phase
not finished yet" log messages.
2016-05-10 00:52:38 +02:00
thorkill
73ae43199c Allow PKT_PROBE in sptps_send_record
sptps_send_record prevented PKT_PROBE to be send in send_sptps_packet.
This occurred mostly when data was on "the wire" for some subnet.
route() would then trigger try_tx/try_udp which would be dropped by
sptps_send_record producing annoying amount of "Handshake phase
not finished yet" log messages.
2016-05-10 00:43:43 +02:00
thorkill
c5f46d3efb Removed backtrace callback 2016-05-10 00:37:39 +02:00