j3d1/tinc
1
0
Fork 0
Code Issues 1 Pull requests Releases Wiki Activity

Fix undefined behaviour when left-shifting signed integers.

Browse source 
Found by -fsanitize=undefined.
This commit is contained in:
Guus Sliepen 2015-07-12 12:33:07 +02:00
parent de7d9ee437
commit b396585383
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/hash.c
View file

@ -29,7 +29,7 @@ static uint32_t hash_function(const void *p, size_t len) {
uint32_t hash = 0; uint32_t hash = 0;
while(true) { while(true) {
for(int i = len > 4 ? 4 : len; --i;) for(int i = len > 4 ? 4 : len; --i;)
hash += q[len - i] << (8 * i); hash += (uint32_t)q[len - i] << (8 * i);
hash *= 0x9e370001UL; // Golden ratio prime. hash *= 0x9e370001UL; // Golden ratio prime.
if(len <= 4) if(len <= 4)
break; break;