j3d1/tinc
1
0
Fork 0
Code Issues 1 Pull requests Releases Wiki Activity

Don't enable the device if the reachable count is zero.

Browse source 
A logic bug was introduced in bd451cfe15
in which running graph() several times with zero reachable nodes had
the effect of calling device_enable() (instead of keeping the device
disabled).

This results in weird behavior when DeviceStandby is enabled, especially
on Windows where calling device_enable() several times in a row corrupts
I/O structures for the device, rendering it unusable.
This commit is contained in:
Etienne Dechamps 2014-09-06 10:43:15 +01:00
parent 9ad656b512
commit 7ac5263765
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/graph.c
View file

@ -292,7 +292,7 @@ static void check_reachability(void) {
if (device_standby) { if (device_standby) {
if (reachable_count == 0 && became_unreachable_count > 0) if (reachable_count == 0 && became_unreachable_count > 0)
device_disable(); device_disable();
else if (reachable_count == became_reachable_count) else if (reachable_count > 0 && reachable_count == became_reachable_count)
device_enable(); device_enable();
} }
} }