j3d1/tinc
1
0
Fork 0
Code Issues 1 Pull requests Releases Wiki Activity

Bug found! Wrong pointer was used for handling multiple ADD_HOST requests

Browse source 
at once. (See line 606.)
This commit is contained in:
Guus Sliepen 2000-04-24 09:39:50 +00:00
parent f6802d349d
commit 16d581be68
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/protocol.c
View file

@ -491,7 +491,7 @@ int ack_h(conn_list_t *cl, unsigned char *d, int len)
{
if(request_handlers[d[1]] == NULL)
syslog(LOG_ERR, "Unknown request %d.", d[1]);
if(request_handlers[d[1]](cl, d, len - 1) < 0)
if(request_handlers[d[1]](cl, d + 1, len - 1) < 0)
return -1;
}
@ -597,12 +597,13 @@ int add_host_h(conn_list_t *cl, unsigned char *d, int len)
/*
again, i'm cheating here. see the comment in ack_h.
Naughty zarq! Now you see what cheating will get you... [GS]
*/
if(len > sizeof(add_host_t)) /* Another ADD_HOST follows */
{
if(request_handlers[d[sizeof(add_host_t)]] == NULL)
syslog(LOG_ERR, "Unknown request %d.", d[sizeof(add_host_t)]);
if(request_handlers[d[sizeof(add_host_t)]](cl, d, len - sizeof(add_host_t)) < 0)
if(request_handlers[d[sizeof(add_host_t)]](cl, d + sizeof(add_host_t), len - sizeof(add_host_t)) < 0)
return -1;
}