j3d1/tinc
1
0
Fork 0
Code Issues 1 Pull requests Releases Wiki Activity

Fix event loop io tree inconsistency on Windows.

Browse source 
On Windows, the event loop io tree uses the Windows Event handle to
differentiate between io_t objects. Unfortunately, there is a bug in
the io_add_event() function (introduced in
2f9a1d4ab5) as it sets the event after
inserting the object into the tree, resulting in objects appearing in
io_tree out of order.

This can lead to crashes on Windows as the event loop is unable to
determine which events fired.
This commit is contained in:
Etienne Dechamps 2014-07-06 12:35:32 +01:00
parent fcf5b53e78
commit 163773d710
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/event.c
View file

@ -91,8 +91,8 @@ void io_add(io_t *io, io_cb_t cb, void *data, int fd, int flags) {
#ifdef HAVE_MINGW #ifdef HAVE_MINGW
void io_add_event(io_t *io, io_cb_t cb, void *data, WSAEVENT event) { void io_add_event(io_t *io, io_cb_t cb, void *data, WSAEVENT event) {
io_add(io, cb, data, -1, 0);
io->event = event; io->event = event;
io_add(io, cb, data, -1, 0);
} }
#endif #endif