j3d1/rustl8710
1
0
Fork 0
mirror of https://github.com/polyfractal/rustl8710.git synced 2024-12-04 12:10:28 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #6 from ghsecuritylab/fix/GSL/prevent_rhostname_overflow

Browse source 
[SECURITY] Prevent `rhostname` array overflow
This commit is contained in:
Zachary Tong 2020-03-09 15:05:28 -04:00 committed by GitHub
commit 550db43b89
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
component/common/network/lwip/lwip_v1.5.0.beta/src/netif/ppp/eap.c
View file

@ -1445,7 +1445,7 @@ static void eap_request(ppp_pcb *pcb, u_char *inp, int id, int len) {
} }
/* Not so likely to happen. */ /* Not so likely to happen. */
if (vallen >= len + sizeof (rhostname)) { if (len - vallen >= sizeof (rhostname)) {
ppp_dbglog("EAP: trimming really long peer name down"); ppp_dbglog("EAP: trimming really long peer name down");
MEMCPY(rhostname, inp + vallen, sizeof (rhostname) - 1); MEMCPY(rhostname, inp + vallen, sizeof (rhostname) - 1);
rhostname[sizeof (rhostname) - 1] = '\0'; rhostname[sizeof (rhostname) - 1] = '\0';
@ -1876,7 +1876,7 @@ static void eap_response(ppp_pcb *pcb, u_char *inp, int id, int len) {
} }
/* Not so likely to happen. */ /* Not so likely to happen. */
if (vallen >= len + sizeof (rhostname)) { if (len - vallen >= sizeof (rhostname)) {
ppp_dbglog("EAP: trimming really long peer name down"); ppp_dbglog("EAP: trimming really long peer name down");
MEMCPY(rhostname, inp + vallen, sizeof (rhostname) - 1); MEMCPY(rhostname, inp + vallen, sizeof (rhostname) - 1);
rhostname[sizeof (rhostname) - 1] = '\0'; rhostname[sizeof (rhostname) - 1] = '\0';