j3d1/realtek_ameba
1
0
Fork 0
mirror of https://github.com/flyingcys/realtek_ameba.git synced 2024-11-01 01:44:16 +00:00
Code Issues Projects Releases Packages Wiki Activity

vallen is verified to be less than len, therefore, it can never

Browse source 
be the case that `vallen >= len + sizeof(rhostname)`.

This PR fixes the check so the `rhostname` array does not overflow.

Reported-by: Github Security Lab <securitylab@github.com>
Signed-off-by: Alvaro Muñoz <pwntester@github.com>
This commit is contained in:
Github Security Lab 2020-03-06 23:36:24 +01:00
parent 796bcbffa0
commit 67dd64abc5
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
sdk-ameba-v4.0b_without_NDA_GCC_V1.0.0/component/common/network/lwip/lwip_v1.5.0.beta/src/netif/ppp/eap.c
View file

@ -1445,7 +1445,7 @@ static void eap_request(ppp_pcb *pcb, u_char *inp, int id, int len) {
}
/* Not so likely to happen. */
if (vallen >= len + sizeof (rhostname)) {
if (len - vallen >= sizeof (rhostname)) {
ppp_dbglog("EAP: trimming really long peer name down");
MEMCPY(rhostname, inp + vallen, sizeof (rhostname) - 1);
rhostname[sizeof (rhostname) - 1] = '\0';
@ -1876,7 +1876,7 @@ static void eap_response(ppp_pcb *pcb, u_char *inp, int id, int len) {
}
/* Not so likely to happen. */
if (vallen >= len + sizeof (rhostname)) {
if (len - vallen >= sizeof (rhostname)) {
ppp_dbglog("EAP: trimming really long peer name down");
MEMCPY(rhostname, inp + vallen, sizeof (rhostname) - 1);
rhostname[sizeof (rhostname) - 1] = '\0';