j3d1/json
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix comparission between integers and floats

Browse source 
Until now it depended on the parameter-order whether
integers and floats were compared as integers or floats.

Appart from being not logical, this might even have meant that
the provided “order” was in fact not that. (not sure here, but I
like to be carefull)
This commit is contained in:
Florian Weber 2015-04-26 14:39:39 +02:00
parent 306695dd25
commit d2771eb1bb
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/json.hpp
View file

@ -1906,8 +1906,8 @@ class basic_json
} }
else if (lhs_type == value_t::number_integer and rhs_type == value_t::number_float) else if (lhs_type == value_t::number_integer and rhs_type == value_t::number_float)
{ {
return lhs.m_value.number_integer == return approx(static_cast<number_float_t>(lhs.m_value.number_integer),
static_cast<number_integer_t>(rhs.m_value.number_float); rhs.m_value.number_float);
} }
else if (lhs_type == value_t::number_float and rhs_type == value_t::number_integer) else if (lhs_type == value_t::number_float and rhs_type == value_t::number_integer)
{ {
@ -1967,8 +1967,8 @@ class basic_json
} }
else if (lhs_type == value_t::number_integer and rhs_type == value_t::number_float) else if (lhs_type == value_t::number_integer and rhs_type == value_t::number_float)
{ {
return lhs.m_value.number_integer < return static_cast<number_float_t>(lhs.m_value.number_integer) <
static_cast<number_integer_t>(rhs.m_value.number_float); rhs.m_value.number_float;
} }
else if (lhs_type == value_t::number_float and rhs_type == value_t::number_integer) else if (lhs_type == value_t::number_float and rhs_type == value_t::number_integer)
{ {

8
src/json.hpp.re2c
View file

@ -1906,8 +1906,8 @@ class basic_json
} }
else if (lhs_type == value_t::number_integer and rhs_type == value_t::number_float) else if (lhs_type == value_t::number_integer and rhs_type == value_t::number_float)
{ {
return lhs.m_value.number_integer == return approx(static_cast<number_float_t>(lhs.m_value.number_integer),
static_cast<number_integer_t>(rhs.m_value.number_float); rhs.m_value.number_float);
} }
else if (lhs_type == value_t::number_float and rhs_type == value_t::number_integer) else if (lhs_type == value_t::number_float and rhs_type == value_t::number_integer)
{ {
@ -1967,8 +1967,8 @@ class basic_json
} }
else if (lhs_type == value_t::number_integer and rhs_type == value_t::number_float) else if (lhs_type == value_t::number_integer and rhs_type == value_t::number_float)
{ {
return lhs.m_value.number_integer < return static_cast<number_float_t>(lhs.m_value.number_integer) <
static_cast<number_integer_t>(rhs.m_value.number_float); rhs.m_value.number_float;
} }
else if (lhs_type == value_t::number_float and rhs_type == value_t::number_integer) else if (lhs_type == value_t::number_float and rhs_type == value_t::number_integer)
{ {