From a6d112ffbf0005cf1a7d61236523bcae89be4ae0 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Wed, 22 Jul 2020 13:39:40 +0200 Subject: [PATCH] :white_check_mark: add regression test for #2281 --- test/cmake_target_include_directories/project/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/cmake_target_include_directories/project/CMakeLists.txt b/test/cmake_target_include_directories/project/CMakeLists.txt index 0f997695..f56786c0 100644 --- a/test/cmake_target_include_directories/project/CMakeLists.txt +++ b/test/cmake_target_include_directories/project/CMakeLists.txt @@ -11,11 +11,11 @@ target_include_directories(with_private_system_target PRIVATE SYSTEM ${nlohmann_ set_target_properties(with_private_system_target PROPERTIES CXX_STANDARD 11) # regression from https://github.com/nlohmann/json/discussions/2281 -add_library(Foo SHARED Foo.cpp Bar.cpp) +add_library(Foo STATIC Foo.cpp Bar.cpp) target_include_directories(Foo PUBLIC ${CMAKE_CURRENT_SOURCE_DIR} ${nlohmann_json_source}/include) set_target_properties(Foo PROPERTIES CXX_STANDARD 11) -add_library(Bar SHARED Bar.cpp) +add_library(Bar STATIC Bar.cpp) target_link_libraries(Bar PRIVATE Foo) target_include_directories(Bar PUBLIC ${CMAKE_CURRENT_SOURCE_DIR} ${nlohmann_json_source}/include) set_target_properties(Bar PROPERTIES CXX_STANDARD 11)