j3d1/json
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

✅ improved test coverage

Browse source
This commit is contained in:
Niels Lohmann 2018-01-14 20:07:38 +01:00
parent f85f4967fe
commit 9d6b3731b9
No known key found for this signature in database
GPG key ID: 7F3CEA63AE251B69
4 changed files with 54 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

23
develop/detail/parsing/binary_writer.hpp
View file

@ -813,7 +813,16 @@ class binary_writer
}
}
char ubjson_prefix(const BasicJsonType& j)
/*!
@brief determine the type prefix of container values
@note This function does not need to be 100% accurate when it comes to
integer limits. In case a number exceeds the limits of int64_t,
this will be detected by a later call to function
write_number_with_ubjson_prefix. Therefore, we return 'L' for any
value that does not fit the previous limits.
*/
char ubjson_prefix(const BasicJsonType& j) const noexcept
{
switch (j.type())
{
@ -841,11 +850,10 @@ class binary_writer
{
return 'l';
}
else if ((std::numeric_limits<int64_t>::min)() <= j.m_value.number_integer and j.m_value.number_integer <= (std::numeric_limits<int64_t>::max)())
else // no check and assume int64_t (see note above)
{
return 'L';
}
break;
}
case value_t::number_unsigned:
@ -866,11 +874,10 @@ class binary_writer
{
return 'l';
}
else if (j.m_value.number_unsigned <= (std::numeric_limits<int64_t>::max)())
else // no check and assume int64_t (see note above)
{
return 'L';
}
break;
}
case value_t::number_float:
@ -885,11 +892,9 @@ class binary_writer
case value_t::object:
return '{';
default:
break;
default: // discarded values
return 'N';
}
return '\0';
}
private: