🚨 fixed some clang-tidy warnings

This commit is contained in:
Niels Lohmann 2018-10-07 18:39:18 +02:00
parent fa722d5ac3
commit 858e75c4df
No known key found for this signature in database
GPG key ID: 7F3CEA63AE251B69
29 changed files with 214 additions and 204 deletions

View file

@ -540,9 +540,11 @@ class binary_writer
case value_t::boolean:
{
if (add_prefix)
{
oa->write_character(j.m_value.boolean
? static_cast<CharType>('T')
: static_cast<CharType>('F'));
}
break;
}
@ -908,32 +910,32 @@ class binary_writer
}
}
static constexpr CharType get_cbor_float_prefix(float)
static constexpr CharType get_cbor_float_prefix(float /*unused*/)
{
return static_cast<CharType>(0xFA); // Single-Precision Float
}
static constexpr CharType get_cbor_float_prefix(double)
static constexpr CharType get_cbor_float_prefix(double /*unused*/)
{
return static_cast<CharType>(0xFB); // Double-Precision Float
}
static constexpr CharType get_msgpack_float_prefix(float)
static constexpr CharType get_msgpack_float_prefix(float /*unused*/)
{
return static_cast<CharType>(0xCA); // float 32
}
static constexpr CharType get_msgpack_float_prefix(double)
static constexpr CharType get_msgpack_float_prefix(double /*unused*/)
{
return static_cast<CharType>(0xCB); // float 64
}
static constexpr CharType get_ubjson_float_prefix(float)
static constexpr CharType get_ubjson_float_prefix(float /*unused*/)
{
return 'd'; // float 32
}
static constexpr CharType get_ubjson_float_prefix(double)
static constexpr CharType get_ubjson_float_prefix(double /*unused*/)
{
return 'D'; // float 64
}
@ -945,5 +947,5 @@ class binary_writer
/// the output
output_adapter_t<CharType> oa = nullptr;
};
}
}
} // namespace detail
} // namespace nlohmann

View file

@ -109,5 +109,5 @@ class output_adapter
private:
output_adapter_t<CharType> oa = nullptr;
};
}
}
} // namespace detail
} // namespace nlohmann

View file

@ -53,6 +53,9 @@ class serializer
// delete because of pointer members
serializer(const serializer&) = delete;
serializer& operator=(const serializer&) = delete;
serializer(serializer&&) noexcept = default;
serializer& operator=(serializer&&) noexcept = default;
~serializer() = default;
/*!
@brief internal implementation of the serialization function
@ -627,5 +630,5 @@ class serializer
/// the indentation string
string_t indent_string;
};
}
}
} // namespace detail
} // namespace nlohmann