j3d1/json
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

🚑 fix for #492

Browse source 
The original test case relied on an invalidated iterator. This error
did not occur before, but only with GCC with -D_GLIBCXX_DEBUG. This
commit fixes the test case. The library is unaffected by this change.
This commit is contained in:
Niels Lohmann 2017-03-09 18:20:26 +01:00
parent a1354184ce
commit 758c4addc1
No known key found for this signature in database
GPG key ID: 7F3CEA63AE251B69
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
test/src/unit-modifiers.cpp
View file

@ -583,10 +583,11 @@ TEST_CASE("modifiers")
SECTION("insert nothing (count = 0)") SECTION("insert nothing (count = 0)")
{ {
auto pos = j_array.end();
auto it = j_array.insert(j_array.end(), 0, 5); auto it = j_array.insert(j_array.end(), 0, 5);
CHECK(j_array.size() == 4); CHECK(j_array.size() == 4);
CHECK(it == pos); // the returned iterator points to the first inserted element;
// there were 4 elements, so it should point to the 5th
CHECK(it == j_array.begin() + 4);
CHECK(j_array == json({1, 2, 3, 4})); CHECK(j_array == json({1, 2, 3, 4}));
} }
} }