🚨 fixed some warnings
This commit is contained in:
parent
d39842e68f
commit
546e2cbf5e
4 changed files with 4 additions and 3 deletions
1
Makefile
1
Makefile
|
@ -136,6 +136,7 @@ pedantic_clang:
|
||||||
-Wno-float-equal \
|
-Wno-float-equal \
|
||||||
-Wno-switch-enum -Wno-covered-switch-default \
|
-Wno-switch-enum -Wno-covered-switch-default \
|
||||||
-Wno-c++2a-compat \
|
-Wno-c++2a-compat \
|
||||||
|
-Wno-c++17-extensions \
|
||||||
-Wno-padded"
|
-Wno-padded"
|
||||||
|
|
||||||
# calling GCC with most warnings
|
# calling GCC with most warnings
|
||||||
|
|
|
@ -620,7 +620,7 @@ class serializer
|
||||||
if (is_negative)
|
if (is_negative)
|
||||||
{
|
{
|
||||||
*buffer_ptr = '-';
|
*buffer_ptr = '-';
|
||||||
abs_value = static_cast<number_unsigned_t>(-1 - x) + 1;
|
abs_value = static_cast<number_unsigned_t>(std::abs(static_cast<std::intmax_t>(x)));
|
||||||
|
|
||||||
// account one more byte for the minus sign
|
// account one more byte for the minus sign
|
||||||
n_chars = 1 + count_digits(abs_value);
|
n_chars = 1 + count_digits(abs_value);
|
||||||
|
|
|
@ -11533,7 +11533,7 @@ class serializer
|
||||||
if (is_negative)
|
if (is_negative)
|
||||||
{
|
{
|
||||||
*buffer_ptr = '-';
|
*buffer_ptr = '-';
|
||||||
abs_value = static_cast<number_unsigned_t>(-1 - x) + 1;
|
abs_value = static_cast<number_unsigned_t>(std::abs(static_cast<std::intmax_t>(x)));
|
||||||
|
|
||||||
// account one more byte for the minus sign
|
// account one more byte for the minus sign
|
||||||
n_chars = 1 + count_digits(abs_value);
|
n_chars = 1 + count_digits(abs_value);
|
||||||
|
|
|
@ -1762,7 +1762,7 @@ TEST_CASE("regression tests")
|
||||||
-54, -28, -26
|
-54, -28, -26
|
||||||
};
|
};
|
||||||
std::string s;
|
std::string s;
|
||||||
for (int i = 0; i < sizeof(data) / sizeof(int); i++)
|
for (unsigned i = 0; i < sizeof(data) / sizeof(int); i++)
|
||||||
{
|
{
|
||||||
s += static_cast<char>(data[i]);
|
s += static_cast<char>(data[i]);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue