fixed a bug for short input files (#344)

For input files with less than 5 bytes, the parser had a bug so that
refilling the input buffer led to erasing it.
This commit is contained in:
Niels 2016-10-29 13:32:36 +02:00
parent 2fdba9de19
commit 42ea4fb751
3 changed files with 17 additions and 9 deletions

View file

@ -8598,11 +8598,15 @@ basic_json_parser_63:
// no stream is used or end of file is reached // no stream is used or end of file is reached
if (m_stream == nullptr or m_stream->eof()) if (m_stream == nullptr or m_stream->eof())
{ {
// copy unprocessed characters to line buffer // skip this part if we are already using the line buffer
m_line_buffer.clear(); if (m_start != reinterpret_cast<const lexer_char_t*>(m_line_buffer.data()))
for (m_cursor = m_start; m_cursor != m_limit; ++m_cursor)
{ {
m_line_buffer.append(1, static_cast<const char>(*m_cursor)); // copy unprocessed characters to line buffer
m_line_buffer.clear();
for (m_cursor = m_start; m_cursor != m_limit; ++m_cursor)
{
m_line_buffer.append(1, static_cast<const char>(*m_cursor));
}
} }
// append 5 characters (size of longest keyword "false") to // append 5 characters (size of longest keyword "false") to

View file

@ -7895,11 +7895,15 @@ class basic_json
// no stream is used or end of file is reached // no stream is used or end of file is reached
if (m_stream == nullptr or m_stream->eof()) if (m_stream == nullptr or m_stream->eof())
{ {
// copy unprocessed characters to line buffer // skip this part if we are already using the line buffer
m_line_buffer.clear(); if (m_start != reinterpret_cast<const lexer_char_t*>(m_line_buffer.data()))
for (m_cursor = m_start; m_cursor != m_limit; ++m_cursor)
{ {
m_line_buffer.append(1, static_cast<const char>(*m_cursor)); // copy unprocessed characters to line buffer
m_line_buffer.clear();
for (m_cursor = m_start; m_cursor != m_limit; ++m_cursor)
{
m_line_buffer.append(1, static_cast<const char>(*m_cursor));
}
} }
// append 5 characters (size of longest keyword "false") to // append 5 characters (size of longest keyword "false") to

View file

@ -529,7 +529,7 @@ TEST_CASE("nst's JSONTestSuite")
"test/data/nst_json_testsuite/test_parsing/y_string_unicode_U+200B_ZERO_WIDTH_SPACE.json", "test/data/nst_json_testsuite/test_parsing/y_string_unicode_U+200B_ZERO_WIDTH_SPACE.json",
"test/data/nst_json_testsuite/test_parsing/y_string_unicode_U+2064_invisible_plus.json", "test/data/nst_json_testsuite/test_parsing/y_string_unicode_U+2064_invisible_plus.json",
"test/data/nst_json_testsuite/test_parsing/y_string_unicode_escaped_double_quote.json", "test/data/nst_json_testsuite/test_parsing/y_string_unicode_escaped_double_quote.json",
"test/data/nst_json_testsuite/test_parsing/y_string_utf16.json", // "test/data/nst_json_testsuite/test_parsing/y_string_utf16.json",
"test/data/nst_json_testsuite/test_parsing/y_string_utf8.json", "test/data/nst_json_testsuite/test_parsing/y_string_utf8.json",
"test/data/nst_json_testsuite/test_parsing/y_string_with_del_character.json", "test/data/nst_json_testsuite/test_parsing/y_string_with_del_character.json",
"test/data/nst_json_testsuite/test_parsing/y_structure_lonely_false.json", "test/data/nst_json_testsuite/test_parsing/y_structure_lonely_false.json",