From 3db14cbfae858707b31419877d37be46bcbd95a3 Mon Sep 17 00:00:00 2001 From: Isaac Nickaein Date: Mon, 24 Jun 2019 15:40:01 +0430 Subject: [PATCH] :memo: Improve doc on const_inter constructor --- include/nlohmann/detail/iterators/iter_impl.hpp | 11 +++++++---- single_include/nlohmann/json.hpp | 11 +++++++---- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/include/nlohmann/detail/iterators/iter_impl.hpp b/include/nlohmann/detail/iterators/iter_impl.hpp index 8492c234..bc87de29 100644 --- a/include/nlohmann/detail/iterators/iter_impl.hpp +++ b/include/nlohmann/detail/iterators/iter_impl.hpp @@ -118,10 +118,13 @@ class iter_impl to iterator is not defined. */ - /* We had to explicitly define the copy constructor for the const - case to circumvent a bug on msvc 2015 debug build. - More info: https://github.com/nlohmann/json/issues/1608 - */ + /*! + @brief const copy constructor + @param[in] other const iterator to copy from + @note This copy constuctor had to be defined explicitely to circumvent a bug + occuring on msvc v19.0 compiler (VS 2015) debug build. For more + information refer to: https://github.com/nlohmann/json/issues/1608 + */ iter_impl(const iter_impl& other) noexcept : m_object(other.m_object), m_it(other.m_it) {} diff --git a/single_include/nlohmann/json.hpp b/single_include/nlohmann/json.hpp index c652b35a..08c4fc64 100644 --- a/single_include/nlohmann/json.hpp +++ b/single_include/nlohmann/json.hpp @@ -7821,10 +7821,13 @@ class iter_impl to iterator is not defined. */ - /* We had to explicitly define the copy constructor for the const - case to circumvent a bug on msvc 2015 debug build. - More info: https://github.com/nlohmann/json/issues/1608 - */ + /*! + @brief const copy constructor + @param[in] other const iterator to copy from + @note This copy constuctor had to be defined explicitely to circumvent a bug + occuring on msvc v19.0 compiler (VS 2015) debug build. For more + information refer to: https://github.com/nlohmann/json/issues/1608 + */ iter_impl(const iter_impl& other) noexcept : m_object(other.m_object), m_it(other.m_it) {}