j3d1/json
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

✅ added a regression test for #380 / #390

Browse source
This commit is contained in:
Niels Lohmann 2016-12-13 21:46:07 +01:00
parent 4e2fb1a533
commit 2f94c30bad
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
README.md
View file

@ -583,6 +583,7 @@ I deeply appreciate the help of the following people.
- [TurpentineDistillery](https://github.com/TurpentineDistillery) pointed to [`std::locale::classic()`](http://en.cppreference.com/w/cpp/locale/locale/classic) to avoid too much locale joggling, found some nice performance improvements in the parser and improved the benchmarking code. - [TurpentineDistillery](https://github.com/TurpentineDistillery) pointed to [`std::locale::classic()`](http://en.cppreference.com/w/cpp/locale/locale/classic) to avoid too much locale joggling, found some nice performance improvements in the parser and improved the benchmarking code.
- [cgzones](https://github.com/cgzones) had an idea how to fix the Coverity scan. - [cgzones](https://github.com/cgzones) had an idea how to fix the Coverity scan.
- [Jared Grubb](https://github.com/jaredgrubb) silenced a nasty documentation warning. - [Jared Grubb](https://github.com/jaredgrubb) silenced a nasty documentation warning.
- [Yixin Zhang](https://github.com/qwename) fixed an integer overflow check.
Thanks a lot for helping out! Thanks a lot for helping out!

7
test/src/unit-regression.cpp
View file

@ -533,4 +533,11 @@ TEST_CASE("regression tests")
json j3 = json::parse("-9223372036854775809"); json j3 = json::parse("-9223372036854775809");
CHECK(j3.is_number_float()); CHECK(j3.is_number_float());
} }
SECTION("issue #380 - bug in overflow detection when parsing integers")
{
json j = json::parse("166020696663385964490");
CHECK(j.is_number_float());
CHECK(j.dump() == "1.66020696663386e+20");
}
} }