j3d1/json
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Still trying to invoke locale-specific behavior in CI

Browse source
This commit is contained in:
Alex Astashyn 2016-12-08 22:13:05 -05:00
parent 38499e84fc
commit 1c029b97c0
1 changed files with 5 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
test/src/unit-regression.cpp
View file

@ -405,46 +405,21 @@ TEST_CASE("regression tests")
SECTION("issue #379 - locale-independent str-to-num") SECTION("issue #379 - locale-independent str-to-num")
{ {
// If I save the locale here and restore it in the end setlocale(LC_NUMERIC, "de_DE.UTF-8");
// of this block, then setLocale(LC_NUMERIC, "de_DE")
// does not actually make snprintf use "," as decimal separator
// on some compilers. I have no idea...
//const std::string orig_locale_name(setlocale(LC_ALL, NULL));
// Still, just setting some comma-using locale does not
// make snprintf output commas on all platforms, so instead
// will change dot to comma in the current locale below
//setlocale(LC_NUMERIC, "de_DE");
auto loc = localeconv();
auto orig_decimal_point = loc->decimal_point;
char comma[] = ",";
loc->decimal_point = comma;
std::array<char, 64> buf;
{ {
// verify that strtod now uses commas as decimal-separator // verify that strtod now uses commas as decimal-separator
const double d1 = std::strtod("3,14", nullptr); CHECK(std::strtod("3,14", nullptr) == 3.14);
CHECK(d1 == 3.14);
// verify that strtod does not understand dots as decimal separator // verify that strtod does not understand dots as decimal separator
const double d2 = std::strtod("3.14", nullptr); CHECK(std::strtod("3.14", nullptr) == 3);
CHECK(d2 == 3);
} }
// verify that parsed correctly despite using strtod internally // verify that parsed correctly despite using strtod internally
const json j1 = json::parse("3.14"); CHECK(json::parse("3.14").get<double>() == 3.14);
CHECK(j1.get<double>() == 3.14);
// check a different code path // check a different code path
const json j2 = json::parse("1.000000000000000000000000000000000000000000000000000000000000000000000000"); CHECK(json::parse("1.000000000000000000000000000000000000000000000000000000000000000000000000").get<double>() == 1.0);
CHECK(j2.get<double>() == 1.0);
loc->decimal_point = orig_decimal_point;
// restore original locale
// setlocale(LC_ALL, orig_locale_name.c_str());
} }