From fdff42bc3d9e94c590b244b5c975a31ff956c725 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Tue, 15 Aug 2017 20:30:01 +0200 Subject: [PATCH 1/2] :construction_worker: forgot to install Cmake on OSX --- .travis.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 7969af18..7a52653b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -42,7 +42,7 @@ matrix: after_success: - make check TEST_PREFIX="valgrind --error-exitcode=1 --leak-check=full " TEST_PATTERN="" - # cLang sanitizer + # clang sanitizer # note: sadly clang's libc++ has errors when running with sanitize, # so we use clang with gcc's libstdc++ which doesn't give those error. # that's why we need to install g++-6 to get the lastest version @@ -267,6 +267,14 @@ matrix: ################ script: + # get CMake (only for systems with brew - macOS) + - | + if [[ !(-x $(which cmake)) && (-x $(which brew)) ]]; then + brew update + brew install cmake + cmake --version + fi + # make sure CXX is correctly set - if [[ "${COMPILER}" != "" ]]; then export CXX=${COMPILER}; fi From 76123fab763bc32a2d7035dab26fa20815152e65 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Tue, 15 Aug 2017 20:49:18 +0200 Subject: [PATCH 2/2] :memo: added note wrt. #667 --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 92d1956a..940b4ef0 100644 --- a/README.md +++ b/README.md @@ -539,6 +539,9 @@ Some important things: * Those methods **MUST** be in your type's namespace (which can be the global namespace), or the library will not be able to locate them (in this example, they are in namespace `ns`, where `person` is defined). * When using `get()`, `your_type` **MUST** be [DefaultConstructible](http://en.cppreference.com/w/cpp/concept/DefaultConstructible). (There is a way to bypass this requirement described later.) * In function `from_json`, use function [`at()`](https://nlohmann.github.io/json/classnlohmann_1_1basic__json_a93403e803947b86f4da2d1fb3345cf2c.html#a93403e803947b86f4da2d1fb3345cf2c) to access the object values rather than `operator[]`. In case a key does not exists, `at` throws an exception that you can handle, whereas `operator[]` exhibits undefined behavior. +* In case your type contains several `operator=` definitions, code like `your_variable = your_json;` [may not compile](https://github.com/nlohmann/json/issues/667). You need to write `your_variable = your_json.get();` instead. +* You do not need to add serializers or deserializers for STL types like `std::vector`: the library already implements these. + #### How do I convert third-party types?