j3d1/esp-open-rtos
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

bugfix/ets_timer.c: race condition while disarming

Browse source 
If `sdk_ets_timer_arm_ms_us` is called right after `vPortExitCritical` inside `sdk_ets_timer_disarm` on line 247 (by an ISR for example, which was my case), execution will loop forever on line 196, since `timer->next!=ETS_TIMER_NOT_ARMED`, which was supposed to be changed in line 248.
By delaying the IRS or context switch until `sdk_ets_timer_disarm` the problem is fixed.
This commit is contained in:
Flavio Bayer 2018-04-13 16:08:03 -03:00 committed by GitHub
parent 524a98ed1a
commit de426c08b6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
open_esplibs/libmain/ets_timer.c
View file

@ -244,9 +244,9 @@ void sdk_ets_timer_disarm(ets_timer_t *timer)
prev = curr; prev = curr;
curr = curr->next; curr = curr->next;
} }
vPortExitCritical();
timer->next = ETS_TIMER_NOT_ARMED; timer->next = ETS_TIMER_NOT_ARMED;
timer->period_ticks = 0; timer->period_ticks = 0;
vPortExitCritical();
} }
/** /**