From c03622871f43a55d55dd36134860383012d691a5 Mon Sep 17 00:00:00 2001 From: Andrej Krutak Date: Thu, 30 Mar 2017 21:59:35 +0200 Subject: [PATCH] Cleanup code and mark init pins argument as const (which it is) --- extras/pwm/pwm.c | 12 ++++++------ extras/pwm/pwm.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/extras/pwm/pwm.c b/extras/pwm/pwm.c index 338dff0..792d899 100644 --- a/extras/pwm/pwm.c +++ b/extras/pwm/pwm.c @@ -29,7 +29,7 @@ typedef struct pwmInfoDefinition uint8_t running; uint16_t freq; - uint16_t dutyCicle; + uint16_t dutyCycle; /* private */ uint32_t _maxLoad; @@ -66,7 +66,7 @@ static void frc1_interrupt_handler(void) pwmInfo._step = step; } -void pwm_init(uint8_t npins, uint8_t* pins) +void pwm_init(uint8_t npins, const uint8_t* pins) { /* Assert number of pins is correct */ if (npins > MAX_PWM_PINS) @@ -127,10 +127,10 @@ void pwm_set_duty(uint16_t duty) { bool output; - pwmInfo.dutyCicle = duty; + pwmInfo.dutyCycle = duty; if (duty > 0 && duty < UINT16_MAX) { pwm_restart(); - return; + return; } // 0% and 100% duty cycle are special cases: constant output. @@ -139,7 +139,7 @@ void pwm_set_duty(uint16_t duty) output = (duty == UINT16_MAX); for (uint8_t i = 0; i < pwmInfo.usedPins; ++i) { - gpio_write(pwmInfo.pins[i].pin, output); + gpio_write(pwmInfo.pins[i].pin, output); } } @@ -154,7 +154,7 @@ void pwm_restart() void pwm_start() { - pwmInfo._onLoad = pwmInfo.dutyCicle * pwmInfo._maxLoad / UINT16_MAX; + pwmInfo._onLoad = pwmInfo.dutyCycle * pwmInfo._maxLoad / UINT16_MAX; pwmInfo._offLoad = pwmInfo._maxLoad - pwmInfo._onLoad; pwmInfo._step = PERIOD_ON; diff --git a/extras/pwm/pwm.h b/extras/pwm/pwm.h index 55b8761..e2e7d75 100644 --- a/extras/pwm/pwm.h +++ b/extras/pwm/pwm.h @@ -16,7 +16,7 @@ extern "C" { #endif -void pwm_init(uint8_t npins, uint8_t* pins); +void pwm_init(uint8_t npins, const uint8_t* pins); void pwm_set_freq(uint16_t freq); void pwm_set_duty(uint16_t duty);