j3d1/esp-open-rtos
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Increase heap to 288 on SNTP test; warnings on robustness

Browse source
This commit is contained in:
Jeff Kletsky 2018-02-27 19:59:40 -08:00
parent bb58626f47
commit 6bd61ae298
2 changed files with 18 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

18
extras/timekeeping/tests/sntp-run/sntp_impl.c
View file

@ -2,7 +2,8 @@
* Test implementation of callback for LWIP SNTP
*
* Production code would likely decide how to handle
* various magnitude changes, and be brisk about it
* various magnitude changes, be robust to outliers,
* and be brisk about it all
*/
/*-
@ -43,9 +44,20 @@
#include "sntp_impl.h"
/**********************************************************
* IMPORTANT: THIS IS A TEST HARNESS, NOT PRODUCTION CODE *
**********************************************************
*
* Spikes in delay of over 200 ms have been observed in testing.
* Such spikes would likely cause both a forward and a backward jump
* in time using this simplistic approach. Increasing the threshold to,
* for example, 250 ms would require 2000 * 250 ms = 500 sec ~ 10 min
* for the time to slew back after a "bad set" or series of "bad" packets.
*
* PRODUCTION CODE SHOULD USE AN APPLICATION-APPROPRIATE CLOCK DISCIPLINE
*/
#ifndef SNTP_IMPL_STEP_THRESHOLD
#define SNTP_IMPL_STEP_THRESHOLD 128000
#define SNTP_IMPL_STEP_THRESHOLD 125000
#endif