From 5f6ccbd1bedb067cc7e029cfd7d39eb49708a68f Mon Sep 17 00:00:00 2001
From: David Kozub <zub.272@gmail.com>
Date: Thu, 3 Oct 2019 21:20:23 +0200
Subject: [PATCH] extras/wificfg: use #if when checking for
configUSE_TRACE_FACILITY
FreeRTOS/Source/include/FreeRTOSConfig.h makes sure configUSE_TRACE_FACILITY
is always defined. But it's defined to 0 when TRACE_FACILITY is disabled.
When #ifdef is used, the guarded blocks of code are always compiled and
this results in link failure when TRACE_FACILITY is in fact not enabled.
---
extras/wificfg/wificfg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/extras/wificfg/wificfg.c b/extras/wificfg/wificfg.c
index 1e4c5d2..fe04e9f 100644
--- a/extras/wificfg/wificfg.c
+++ b/extras/wificfg/wificfg.c
@@ -1540,7 +1540,7 @@ static int handle_wificfg_challenge_post(int s, wificfg_method method,
return wificfg_write_string(s, http_redirect_header);
}
-#ifdef configUSE_TRACE_FACILITY
+#if configUSE_TRACE_FACILITY
static const char *http_tasks_content[] = {
#include "content/tasks.html"
};
@@ -1638,7 +1638,7 @@ static const wificfg_dispatch wificfg_dispatch_list[] = {
{"/challenge.html", HTTP_METHOD_POST, handle_wificfg_challenge_post, false},
{"/wificfg/restart.html", HTTP_METHOD_POST, handle_restart_post, true},
{"/wificfg/erase.html", HTTP_METHOD_POST, handle_erase_post, true},
-#ifdef configUSE_TRACE_FACILITY
+#if configUSE_TRACE_FACILITY
{"/tasks", HTTP_METHOD_GET, handle_tasks, false},
{"/tasks.html", HTTP_METHOD_GET, handle_tasks, false},
#endif /* configUSE_TRACE_FACILITY */