j3d1/esp-open-rtos
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix for negative int8 in sysparam. Tests update.

Browse source
This commit is contained in:
sheinz 2016-11-28 09:59:12 +02:00
parent 8b9e757904
commit 2f611dfbc0
2 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
core/sysparam.c
View file

@ -1008,7 +1008,7 @@ sysparam_status_t sysparam_set_int32(const char *key, int32_t value) {
} }
sysparam_status_t sysparam_set_int8(const char *key, int8_t value) { sysparam_status_t sysparam_set_int8(const char *key, int8_t value) {
return sysparam_set_int32(key, value); return sysparam_set_data(key, (const uint8_t *)&value, sizeof(value), true);
} }
sysparam_status_t sysparam_set_bool(const char *key, bool value) { sysparam_status_t sysparam_set_bool(const char *key, bool value) {

4
tests/cases/07_sysparam.c
View file

@ -218,11 +218,9 @@ static void verify_test_values(test_data_t *data)
TEST_ASSERT_EQUAL_INT(test_data_get_int32(data), actual_int32); TEST_ASSERT_EQUAL_INT(test_data_get_int32(data), actual_int32);
break; break;
case VALUE_INT8: case VALUE_INT8:
/* fails
status = sysparam_get_int8(key_buf, &actual_int8); status = sysparam_get_int8(key_buf, &actual_int8);
TEST_ASSERT_EQUAL_INT(status, SYSPARAM_OK); TEST_ASSERT_EQUAL_INT(status, SYSPARAM_OK);
TEST_ASSERT_EQUAL_INT(test_data_get_int8(data), actual_int8); TEST_ASSERT_EQUAL_INT(test_data_get_int8(data), actual_int8);
*/
break; break;
case VALUE_BOOL: case VALUE_BOOL:
status = sysparam_get_bool(key_buf, &actual_bool); status = sysparam_get_bool(key_buf, &actual_bool);
@ -297,13 +295,11 @@ static void a_07_sysparam_basic_test(void)
TEST_ASSERT_EQUAL_INT(status, SYSPARAM_OK); TEST_ASSERT_EQUAL_INT(status, SYSPARAM_OK);
TEST_ASSERT_EQUAL_INT(-123, int32_val); TEST_ASSERT_EQUAL_INT(-123, int32_val);
/* fails
status = sysparam_set_int8("int_2", -34); status = sysparam_set_int8("int_2", -34);
TEST_ASSERT_EQUAL_INT(status, SYSPARAM_OK); TEST_ASSERT_EQUAL_INT(status, SYSPARAM_OK);
status = sysparam_get_int8("int_2", &int8_val); status = sysparam_get_int8("int_2", &int8_val);
TEST_ASSERT_EQUAL_INT(status, SYSPARAM_OK); TEST_ASSERT_EQUAL_INT(status, SYSPARAM_OK);
TEST_ASSERT_EQUAL_INT(-34, int8_val); TEST_ASSERT_EQUAL_INT(-34, int8_val);
*/
status = sysparam_set_string("str_1", "test string"); status = sysparam_set_string("str_1", "test string");
TEST_ASSERT_EQUAL_INT(status, SYSPARAM_OK); TEST_ASSERT_EQUAL_INT(status, SYSPARAM_OK);