j3d1/bearssl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Better handling of inet_ntop() failures (which should not happen in practice, since we filter on address family, but let's be cautious).

Browse source
This commit is contained in:
Thomas Pornin 2016-11-12 15:30:47 +01:00
parent 0d974e1c9c
commit 16d0864818
2 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tools/client.c
View file

@ -70,7 +70,9 @@ host_connect(const char *host, const char *port, int verbose)
addr = NULL; addr = NULL;
} }
if (addr != NULL) { if (addr != NULL) {
inet_ntop(p->ai_family, addr, tmp, sizeof tmp); if (!inet_ntop(p->ai_family, addr, tmp, sizeof tmp)) {
strcpy(tmp, "<invalid>");
}
} else { } else {
sprintf(tmp, "<unknown family: %d>", sprintf(tmp, "<unknown family: %d>",
(int)sa->sa_family); (int)sa->sa_family);

4
tools/server.c
View file

@ -87,7 +87,9 @@ host_bind(const char *host, const char *port, int verbose)
sa_len = p->ai_addrlen; sa_len = p->ai_addrlen;
} }
if (addr != NULL) { if (addr != NULL) {
inet_ntop(p->ai_family, addr, tmp, sizeof tmp); if (!inet_ntop(p->ai_family, addr, tmp, sizeof tmp)) {
strcpy(tmp, "<invalid>");
}
} else { } else {
sprintf(tmp, "<unknown family: %d>", sprintf(tmp, "<unknown family: %d>",
(int)sa->sa_family); (int)sa->sa_family);